From: John Hubbard <jhubbard@nvidia.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/5] fstests: add MAINTAINERS and get_maintainer.pl files
Date: Thu, 6 Apr 2023 13:52:55 -0700 [thread overview]
Message-ID: <40e95eb5-66d5-7504-968f-a29a50ea3b10@nvidia.com> (raw)
In-Reply-To: <20230406204824.xd7526whlmc6ghr4@zlang-mailbox>
On 4/6/23 13:48, Zorro Lang wrote:
...
>>> The MAINTAINERS and get_maintainer.pl are copied from linux project,
>>> then made some changes for fstests specially.
>>
>> Hi Zorro,
>>
>> Instead of forking 23,000+ lines of MAINTAINERS and 2600+ lines of
>> script into a strange tools/ location ("tools/" would then mean fstests,
>> and "scripts/" would mean "everything else), this upgrade really should
>> simply be done in place.
>>
>> I don't see much in the following patches that *truly* requires forking
>> these files. And if you fix them up in place, then more people will be
>> able to find the fstests maintainers easily, too.
>
> Hi John,
>
> Thanks for your reviewing.
>
> What's the meaning of "fix them up in place"? Do you suggest to change
> the location/path of the the MAINTAINERS file and get_maintainer script,
> or rewrite them simply and totally (from zero)?
>
I meant, change MAINTAINERS and scripts/get_maintainer.pl directly, so
as to get the new information about fstests and maintainers. That
requires some effort, because you have to keep the existing functionality
working, but I do think it's worth the effort.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2023-04-06 20:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 17:14 [RFC PATCH 0/5] fstests specific MAINTAINERS file Zorro Lang
2023-04-04 17:14 ` [PATCH 1/5] fstests: add MAINTAINERS and get_maintainer.pl files Zorro Lang
2023-04-04 23:21 ` Darrick J. Wong
2023-04-06 20:10 ` John Hubbard
2023-04-06 20:48 ` Zorro Lang
2023-04-06 20:52 ` John Hubbard [this message]
2023-04-08 4:14 ` Zorro Lang
2023-04-08 4:54 ` John Hubbard
2023-04-04 17:14 ` [PATCH 2/5] tools/get_maintainer.pl: remove penguin chiefs Zorro Lang
2023-04-04 17:14 ` [PATCH 3/5] fstests/MAINTAINERS: add supported mailing list Zorro Lang
2023-04-04 22:16 ` Eric Biggers
2023-04-04 23:22 ` Darrick J. Wong
2023-04-05 14:02 ` Zorro Lang
2023-04-04 23:21 ` Darrick J. Wong
2023-04-05 4:04 ` Steve French
2023-04-05 7:49 ` Christian Brauner
2023-04-05 9:52 ` Jan Kara
2023-04-06 0:25 ` Xiubo Li
2023-04-06 1:53 ` [f2fs-dev] " Chao Yu
2023-04-04 17:14 ` [PATCH 4/5] fstests/MAINTAINERS: add some specific reviewers Zorro Lang
2023-04-04 23:23 ` Darrick J. Wong
2023-04-05 7:29 ` Amir Goldstein
2023-04-05 7:47 ` Christian Brauner
2023-04-06 5:02 ` Zorro Lang
2023-04-06 7:49 ` Christian Brauner
2023-04-04 17:14 ` [PATCH 5/5] fstests/MAINTAINERS: add a co-maintainer for btrfs testing part Zorro Lang
2023-04-04 23:26 ` Darrick J. Wong
2023-04-06 14:17 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40e95eb5-66d5-7504-968f-a29a50ea3b10@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox