From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F4905A7B8 for ; Wed, 23 Oct 2024 03:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729654078; cv=none; b=D1BIDVd2GC5IE1GARPY1RSbFb4wvO3BtZNUurb/5CFp2KFlwsyhH+4n803ZJEbN5F8/GoqXEjBZywi364rdQ/4yn44IlpvwEbdzvUTFn6hlrUqkmsMXViCege2LJxBiu8l2charpslay6mJBzcLdyPnE69iE1RMOxOEWx6g+k7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729654078; c=relaxed/simple; bh=FVNEUeJZTBZp+VQNGgY0hojOs1npYOxyXS6RLQ00QqU=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=ddc4kUOACJz+dTMiw3sPOuhcm4qI0maRlTSBSew7DI85ghn/oq2EeaxZnM+QG3m9WgkvCb9UJZQxVzkbx4aua0jHcC/YdS5ue88Suz2rM6k8xLliO4olYOvg/6sRpy7zxFtgOku26LZ3CivNl4EF7xLvNDqE4IV08QHgZhVQYxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hwxwXNYq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hwxwXNYq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3F2AC4CEC3; Wed, 23 Oct 2024 03:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729654078; bh=FVNEUeJZTBZp+VQNGgY0hojOs1npYOxyXS6RLQ00QqU=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=hwxwXNYqCOUkuRi0mgDEyn/3hv6AskvyP+PXfN3TJkLgh4J2Itxy57duDogFAUuqW 6CTaOlykmJrNyLdZYDfrAJ0mzfxZGTv97tJGwzrRGsZD+Fbml5fGQVBTzrpTzpUgZL lr6Ulv7UOkxV+D2oBJEzRjaaZgcFECNF5h7H/D7pqCJrQG+osYP8T94sKZsOCqYgT8 tetERVCP/lp4WDg05/KaFB8BDdk1kaycW5drVb3NEu6b8lEPlmvU3Fipx8DZDlOi7v t9JlrZ+P1u2E+nvJq8Dq0cv8fyXJ3J4vWMHha3VP/yjOrKZTRTbnuNS0t/PujvQnBC TNkWXoPH+ywbQ== Message-ID: <419435a0-b4f0-43f7-bac9-2fb5dabb42f2@kernel.org> Date: Wed, 23 Oct 2024 11:27:54 +0800 Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Chao Yu , fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim Subject: Re: [PATCH 1/2] f2fs/006: add testcase to check out-of-space case To: Zorro Lang References: <20241015025106.3203676-1-chao@kernel.org> <20241023023744.nvnuavzus26gjdj5@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> <6ffdf1df-e4a3-4799-81d4-22f206beb720@kernel.org> <20241023031707.povvhtilr66bv2vi@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20241023031707.povvhtilr66bv2vi@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/10/23 11:17, Zorro Lang wrote: > On Wed, Oct 23, 2024 at 10:53:09AM +0800, Chao Yu wrote: >> On 2024/10/23 10:37, Zorro Lang wrote: >>> On Tue, Oct 15, 2024 at 10:51:05AM +0800, Chao Yu wrote: >>>> This is a regression test to check whether f2fs handles dirty >>>> data correctly when checkpoint is disabled, if lfs mode is on, >>>> it will trigger OPU for all overwritten data, this will cost >>>> free segments, so f2fs must account overwritten data as OPU >>>> data when calculating free space, otherwise, it may run out >>>> of free segments in f2fs' allocation function, resulting in >>>> panic. >>>> >>>> Cc: Jaegeuk Kim >>>> Signed-off-by: Chao Yu >>>> --- >>>> tests/f2fs/006 | 52 ++++++++++++++++++++++++++++++++++++++++++++++ >>>> tests/f2fs/006.out | 6 ++++++ >>>> 2 files changed, 58 insertions(+) >>>> create mode 100755 tests/f2fs/006 >>>> create mode 100644 tests/f2fs/006.out >>>> >>>> diff --git a/tests/f2fs/006 b/tests/f2fs/006 >>>> new file mode 100755 >>>> index 00000000..b359ef8f >>>> --- /dev/null >>>> +++ b/tests/f2fs/006 >>>> @@ -0,0 +1,52 @@ >>>> +#! /bin/bash >>>> +# SPDX-License-Identifier: GPL-2.0 >>>> +# Copyright (c) 2024 Oppo. All Rights Reserved. >>>> +# >>>> +# FS QA Test No. f2fs/006 >>>> +# >>>> +# This is a regression test to check whether f2fs handles dirty >>>> +# data correctly when checkpoint is disabled, if lfs mode is on, >>>> +# it will trigger OPU for all overwritten data, this will cost >>>> +# free segments, so f2fs must account overwritten data as OPU >>>> +# data when calculating free space, otherwise, it may run out >>>> +# of free segments in f2fs' allocation function, resulting in >>>> +# panic. >>>> +# >>>> +. ./common/preamble >>>> +_begin_fstest auto quick >>>> + >>>> +_cleanup() >>>> +{ >>>> + rm -f $img >>>> + _scratch_unmount >> $seqres.full >>>> + cd / >>>> + rm -r -f $tmp.* >>>> +} >>>> + >>>> +_require_scratch >>>> +_scratch_mkfs >> $seqres.full >>>> +_scratch_mount >> $seqres.full >>>> + >>>> +img=$SCRATCH_MNT/f2fs.img >>>> +mnt=$SCRATCH_MNT/f2fs.mnt >>>> +testfile=$mnt/testfile >>>> + >>>> +mkdir $mnt >>>> +dd if=/dev/zero of=$img bs=1M count=100 2>/dev/null >>>> +$MKFS_F2FS_PROG -f $img >/dev/null 2>&1 >>>> +sync >>>> + >>>> +# use mode=lfs to let f2fs always triggers OPU >>>> +mount -t $FSTYP -o loop,mode=lfs,checkpoint=disable:10%,noinline_dentry $img $mnt >>> >>> Hi Chao, >>> >>> Is the loop device necessary? What if use SCRATCH_DEV and SCRATCH_MNT directly? >> >> Hi Zorro, >> >> It uses loop device to limit image size, so that we can speed >> up padding steps of the test since it depends on ENOSPC state. >> >> Or maybe we can mkfs.f2fs $SCRATCH_DEV w/ specified sector size? >> Any suggestion? > > Can scratch_mkfs_sized() help? I saw it supports f2fs. Yes, let me update this patch, thanks. Thanks, > > Thanks, > Zorro > >> >> Thanks, >> >>> >>> Thanks, >>> Zorro >>> >>>> + >>>> +dd if=/dev/zero of=$testfile bs=1M count=50 2>/dev/null >>>> + >>>> +# it may run out of free space of f2fs and hang kernel >>>> +dd if=/dev/zero of=$testfile bs=1M count=50 conv=notrunc conv=fsync >>>> +dd if=/dev/zero of=$testfile bs=1M count=50 conv=notrunc conv=fsync >>>> + >>>> +mount -o remount,checkpoint=enable $mnt >>>> +umount $mnt >>>> + >>>> +status=0 >>>> +exit >>>> diff --git a/tests/f2fs/006.out b/tests/f2fs/006.out >>>> new file mode 100644 >>>> index 00000000..a2c7ba48 >>>> --- /dev/null >>>> +++ b/tests/f2fs/006.out >>>> @@ -0,0 +1,6 @@ >>>> +QA output created by 006 >>>> +50+0 records in >>>> +50+0 records out >>>> +dd: error writing '/mnt/scratch_f2fs/f2fs.mnt/testfile': No space left on device >>>> +3+0 records in >>>> +2+0 records out >>>> -- >>>> 2.40.1 >>>> >>> >> >