From: Ritesh Harjani <riteshh@linux.ibm.com>
To: fstests@vger.kernel.org
Cc: guan@eryu.me, linux-ext4@vger.kernel.org,
anju@linux.vnet.ibm.com, Eryu Guan <eguan@redhat.com>,
Ritesh Harjani <riteshh@linux.ibm.com>
Subject: [PATCH 1/2] check: source common/rc again if TEST_DEV was recreated
Date: Fri, 4 Dec 2020 16:13:53 +0530 [thread overview]
Message-ID: <41edde3b32602dbbad028eec4568875427987cea.1607078368.git.riteshh@linux.ibm.com> (raw)
In-Reply-To: <cover.1607078368.git.riteshh@linux.ibm.com>
From: Eryu Guan <eguan@redhat.com>
If TEST_DEV is recreated by check, FSTYP derived from TEST_DEV
previously could be changed too and might not reflect the reality.
So source common/rc again with correct FSTYP to get fs-specific
configs, e.g. common/xfs.
For example, using this config-section config file, and run section
ext4 first then xfs, you can see:
our local _scratch_mkfs routine ...
./common/rc: line 825: _scratch_mkfs_xfs: command not found
check: failed to mkfs $SCRATCH_DEV using specified options
local.config:
[default]
RECREATE_TEST_DEV=true
TEST_DEV=/dev/sda5
SCRATCH_DEV=/dev/sda6
TEST_DIR=/mnt/test
SCRATCH_MNT=/mnt/scratch
[ext4]
MKFS_OPTIONS="-b 4096"
FSTYP=ext4
[xfs]
FSTYP=xfs
MKFS_OPTIONS="-f -b size=4k"
Tested-by: Ritesh Harjani <riteshh@linux.ibm.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
---
check | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/check b/check
index 83f6fc8bdf3e..c6ad1d6c0733 100755
--- a/check
+++ b/check
@@ -630,6 +630,10 @@ function run_section()
status=1
exit
fi
+ # TEST_DEV has been recreated, previous FSTYP derived from
+ # TEST_DEV could be changed, source common/rc again with
+ # correct FSTYP to get FSTYP specific configs, e.g. common/xfs
+ . common/rc
_prepare_test_list
elif [ "$OLD_TEST_FS_MOUNT_OPTS" != "$TEST_FS_MOUNT_OPTS" ]; then
_test_unmount 2> /dev/null
--
2.26.2
next prev parent reply other threads:[~2020-12-04 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 10:43 [PATCH 0/2] Section handling patch and huge sparse file generic/618 Ritesh Harjani
2020-12-04 10:43 ` Ritesh Harjani [this message]
2020-12-04 10:43 ` [PATCH 2/2] generic: Add test to check for mounting a huge sparse dm device Ritesh Harjani
2020-12-06 13:50 ` Eryu Guan
2020-12-06 14:14 ` Eryu Guan
2020-12-07 8:37 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41edde3b32602dbbad028eec4568875427987cea.1607078368.git.riteshh@linux.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=anju@linux.vnet.ibm.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox