Re: [PATCHv2] generic: add fcntl corner cases tests

[Jeff Layton <jlayton@kernel.org>]

On Fri, 2024-02-02 at 20:27 +0800, Zorro Lang wrote:
> On Fri, Feb 02, 2024 at 07:19:53AM -0500, Alexander Aring wrote:
> > Hi Zorro,
> > 
> > On Fri, Feb 2, 2024 at 7:04 AM Zorro Lang <zlang@redhat.com> wrote:
> > > 
> > > On Thu, Feb 01, 2024 at 12:10:44PM -0500, Jeff Layton wrote:
> > > > On Mon, 2023-09-25 at 16:18 -0400, Alexander Aring wrote:
> > > > > This patch adds fcntl corner cases that was being used to confirm issues
> > > > > on a GFS2 filesystem. The GFS2 filesystem has it's own ->lock()
> > > > > implementation and in those corner cases issues was being found and
> > > > > fixed.
> > > > > 
> > > > > Signed-off-by: Alexander Aring <aahringo@redhat.com>
> > > > > ---
> > > > > changes since v2:
> > > > > - move fcntl tests into one fcntl c file
> > > > > - remove ofd and same owner tests, should be reflected by only one test
> > > > > - simplify commit message (remove testname out of it)
> > > > > - add error messages in fcntl.c to give more information if an error
> > > > >   occur
> > > > > 
> > > > >  src/Makefile          |   3 +-
> > > > >  src/fcntl.c           | 322 ++++++++++++++++++++++++++++++++++++++++++
> > > > >  tests/generic/732     |  32 +++++
> > > > >  tests/generic/732.out |   2 +
> > > > >  4 files changed, 358 insertions(+), 1 deletion(-)
> > > > >  create mode 100644 src/fcntl.c
> > > > >  create mode 100755 tests/generic/732
> > > > >  create mode 100644 tests/generic/732.out
> > > > > 
> > > > > diff --git a/src/Makefile b/src/Makefile
> > > > > index 2815f919..67f936d3 100644
> > > > > --- a/src/Makefile
> > > > > +++ b/src/Makefile
> > > > > @@ -19,7 +19,8 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
> > > > >     t_ofd_locks t_mmap_collision mmap-write-concurrent \
> > > > >     t_get_file_time t_create_short_dirs t_create_long_dirs t_enospc \
> > > > >     t_mmap_writev_overlap checkpoint_journal mmap-rw-fault allocstale \
> > > > > -   t_mmap_cow_memory_failure fake-dump-rootino dio-buf-fault rewinddir-test
> > > > > +   t_mmap_cow_memory_failure fake-dump-rootino dio-buf-fault rewinddir-test \
> > > > > +   fcntl
> > > > 
> > > > I think this function needs a less-generic name than "fcntl". Other the
> > > > lock tests themselves look like a nice addition though.
> > > 
> > > Yeah, the "fcntl" name is too "big", please rename it to show what it trys
> > > to test. Hi Alexander, you can tell me the new name you'd like to change,
> > > if you don't want to send a V2. That might help to catch the fstests release
> > > of this weekend :)
> > > 
> > 
> > I was thinking about "fcntl_corner_tests", if this is okay.
> 
> Good to me, I'm rename to that if no more objection :)
> 
> 

Can we make it "fcntl_lock_corner_tests"?

These tests are all about file locking, but fcntl() is a generic system
call that does a lot of different things besides that.
-- 
Jeff Layton <jlayton@kernel.org>