From: Jeff Layton <jlayton@kernel.org>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: linux-fsdevel@vger.kernel.org, fstests@vger.kernel.org,
ebiederm@xmission.com
Subject: Re: What's up with "locks: change POSIX lock ownership on execve when files_struct is displaced"?
Date: Sat, 19 May 2018 19:51:15 -0400 [thread overview]
Message-ID: <4cb7ba897fd4b5641be680cd599e74dd0c8e41bf.camel@kernel.org> (raw)
In-Reply-To: <20180519194711.GA21362@thunk.org>
On Sat, 2018-05-19 at 15:47 -0400, Theodore Y. Ts'o wrote:
> There is quite of noise currently with xfstests failures. In addition
> to the fsync/EIO failures, there is also something going on with
> dm-thin, etc. And then there's generic/484, which is failing for all
> ext4 configs.
>
> According to test script for generic/484, the test failure is fixed by
> the patch:
>
> locks: change POSIX lock ownership on execve when files_struct is displaced
>
> From what I can tell, the patch was last submitted on March 17th, with
> comments from Eric Beiderman on April 2nd and 3rd --- but nothing
> since then:
>
> https://lists.gt.net/linux/kernel/2941364
>
> Are you still hoping to land this patch for 4.17?
>
> Thanks, regards,
>
> - Ted
No, it's not suitable for inclusion. After I sent the above patch, I
realized that it would break some important filesystems (like NFS).
Eric sounded like he had the best approach to fix it, but it's non-
trivial and somewhat outside the bounds of the locking code. I haven't
had time to attempt a patch for it so far.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2018-05-19 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 19:47 What's up with "locks: change POSIX lock ownership on execve when files_struct is displaced"? Theodore Y. Ts'o
2018-05-19 23:51 ` Jeff Layton [this message]
2018-05-20 1:13 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cb7ba897fd4b5641be680cd599e74dd0c8e41bf.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ebiederm@xmission.com \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox