Re: [PATCH v2 0/5] generic: add a couple of MMAP CoW tests

[Shiyang Ruan <ruansy.fnst@fujitsu.com>]

在 2021/11/7 21:31, Eryu Guan 写道:
> On Fri, Nov 05, 2021 at 12:52:17PM +0800, Shiyang Ruan wrote:
>> There is a set of CoW tests which is to
>>    > Check what happens if we BufferedIO/DIO CoW blocks 2-4 of a page's worth
>>    > of blocks when the second block is a regular/unwritten/hole/delalloc/all
>>    > block.
>> I think a test of MMAP CoW is also needed for these kind of testsets.  So,
>> add MMAP CoW for each case.
>>
>> Shiyang Ruan (5):
>>    generic/xxx: Add MMAP CoW test for 'regular' case
>>    generic/xxx: Add MMAP CoW test for 'unwritten' case
>>    generic/xxx: Add MMAP CoW test for 'hole' case
>>    generic/xxx: Add MMAP CoW test for 'delalloc' case
>>    generic/xxx: Add MMAP CoW test for 'all' case
> 
> Thanks for all these tests!
> 
> You could remove the 'xxx' part from patch summary, and for new tests
> you don't have to write the specific test seq number in summary,
> something like below is fine
> 
>     generic: add mmap CoW test for 'regular' case
> 
> As test seq number will always change on commit, there's no need to keep
> such a place holder.

Got it.  Thanks.

--
Ruan
> 
> Thanks,
> Eryu
> 
>>
>>   tests/generic/900     |  75 +++++++++++++++++++++++
>>   tests/generic/900.out |   6 ++
>>   tests/generic/901     |  76 ++++++++++++++++++++++++
>>   tests/generic/901.out |   6 ++
>>   tests/generic/902     |  70 ++++++++++++++++++++++
>>   tests/generic/902.out |   6 ++
>>   tests/generic/903     |  76 ++++++++++++++++++++++++
>>   tests/generic/903.out |   6 ++
>>   tests/generic/904     | 135 ++++++++++++++++++++++++++++++++++++++++++
>>   tests/generic/904.out |  82 +++++++++++++++++++++++++
>>   10 files changed, 538 insertions(+)
>>   create mode 100755 tests/generic/900
>>   create mode 100644 tests/generic/900.out
>>   create mode 100755 tests/generic/901
>>   create mode 100644 tests/generic/901.out
>>   create mode 100755 tests/generic/902
>>   create mode 100644 tests/generic/902.out
>>   create mode 100755 tests/generic/903
>>   create mode 100644 tests/generic/903.out
>>   create mode 100755 tests/generic/904
>>   create mode 100644 tests/generic/904.out
>>
>> -- 
>> 2.33.0
>>
>>