From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org, linux-nfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 1/5] src/copy_file_range: Add a program for testing vfs_copy_file_range()
Date: Tue, 17 May 2016 10:47:42 -0400 [thread overview]
Message-ID: <4fbb6f1b-5c7f-7afe-b414-0f213870a328@Netapp.com> (raw)
In-Reply-To: <20160516232036.GT26977@dastard>
On 05/16/2016 07:20 PM, Dave Chinner wrote:
> On Fri, May 13, 2016 at 04:50:48PM -0400, Anna Schumaker wrote:
>> This will be used by the various copy tests to call the Linux
>> copy_file_range() system call. I used src/cloner.c as a reference while
>> writing this tool.
>
> Hmmm - I'd much prefer to see this added to xfs_io as it's a kernel
> syscall that lots of filesystems will eventually implement. A
> one-off binary for xfstests is fine for non-standard or deeply
> filesysetm specific stuff, but if it's generic we try to put it into
> xfs_io so that it's available to everyone writing scripts, not just
> xfstests....
Ah, that makes sense. Thanks for explaining the convention! I'll look into adding it to the xfs_io program instead. Should I send that patch to a different mailing list than fstests@vger.kernel.org?
Thanks,
Anna
>
> Cheers,
>
> Dave.
>
next prev parent reply other threads:[~2016-05-17 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 20:50 [PATCH 0/5] Add copy_file_range() tests Anna Schumaker
2016-05-13 20:50 ` [PATCH 1/5] src/copy_file_range: Add a program for testing vfs_copy_file_range() Anna Schumaker
2016-05-16 23:20 ` Dave Chinner
2016-05-17 14:47 ` Anna Schumaker [this message]
2016-05-17 17:48 ` Darrick J. Wong
2016-05-17 17:52 ` Anna Schumaker
2016-05-13 20:50 ` [PATCH 2/5] generic/343: Add copy to new file test Anna Schumaker
2016-05-13 20:50 ` [PATCH 3/5] generic/344: Add small copies " Anna Schumaker
2016-05-13 20:50 ` [PATCH 4/5] generic/345: Add copy test that overwrites data Anna Schumaker
2016-05-13 20:50 ` [PATCH 5/5] generic/346: Add a copy test for overwriting small amounts of data Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fbb6f1b-5c7f-7afe-b414-0f213870a328@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox