From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>, fstests@vger.kernel.org
Subject: [PATCH V2] generic/317,318: fail gracefully if userns not supported
Date: Mon, 16 Jun 2014 21:44:05 -0500 [thread overview]
Message-ID: <539FAB75.7000504@sandeen.net> (raw)
In-Reply-To: <539B6E3A.4060008@redhat.com>
generic/317 and generic/318 fail un-gracefully on older kernels
which don't support userns; fix that by running a simple test
as a prerequisite and fail gracefully if needed.
Roll that in with the test for executable presence, and make
a new _require_userns()
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: _require_userns
diff --git a/common/rc b/common/rc
index f27ee53..97ac862 100644
--- a/common/rc
+++ b/common/rc
@@ -2115,6 +2115,12 @@ _require_relatime()
_scratch_unmount
}
+_require_userns()
+{
+ [ -x src/nsexec ] || _notrun "src/nsexec executable not found"
+ src/nsexec -U true 2>/dev/null || _notrun "userns not supported by this kernel"
+}
+
_create_loop_device()
{
file=$1
diff --git a/tests/generic/317 b/tests/generic/317
index e016a42..efa37c7 100755
--- a/tests/generic/317
+++ b/tests/generic/317
@@ -53,7 +53,6 @@ _supported_fs generic
# only Linux supports user namespace
_supported_os Linux
-[ -x $nsexec ] || _notrun "$nsexec executable not found"
[ -x $lstat64 ] || _notrun "$lstat64 executable not found"
rm -f $seqres.full
@@ -62,6 +61,7 @@ _require_scratch
_need_to_be_root
_require_user
_require_ugid_map
+_require_userns
qa_user_id=`grep $qa_user /etc/passwd |awk -F: '{print $3}'`
_filter_output()
diff --git a/tests/generic/318 b/tests/generic/318
index 0bfbba0..8237434 100755
--- a/tests/generic/318
+++ b/tests/generic/318
@@ -55,8 +55,6 @@ _supported_fs generic
# only Linux supports user namespace
_supported_os Linux
-[ -x $nsexec ] || _notrun "$nsexec executable not found"
-
rm -f $seqres.full
_require_scratch
@@ -64,6 +62,7 @@ _need_to_be_root
_acl_setup_ids
_require_acls
_require_ugid_map
+_require_userns
ns_acl1=0
ns_acl2=`expr $acl2 - $acl1`
ns_acl3=`expr $acl3 - $acl1`
next prev parent reply other threads:[~2014-06-17 2:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 21:33 [PATCH] generic/317,318: fail gracefully if userns not supported Eric Sandeen
2014-06-17 2:10 ` Dave Chinner
2014-06-17 2:44 ` Eric Sandeen [this message]
2014-06-17 7:46 ` [PATCH V2] " Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539FAB75.7000504@sandeen.net \
--to=sandeen@sandeen.net \
--cc=fstests@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox