From: "gux.fnst" <gux.fnst@cn.fujitsu.com>
To: "Dave Chinner" <david@fromorbit.com>,
"Lukáš Czerner" <lczerner@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfstests: add test for ext4 fallocate collapse range check
Date: Wed, 25 Jun 2014 18:05:18 +0800 [thread overview]
Message-ID: <53AA9EDE.8020001@cn.fujitsu.com> (raw)
In-Reply-To: <20140619065644.GL4453@dastard>
On 06/19/2014 02:56 PM, Dave Chinner wrote:
> On Thu, Jun 19, 2014 at 01:50:04PM +0800, Xing Gu wrote:
>> This is a test to verify the procedure which checks whether
>> offset + len is bigger than i_size is removed from do_fallocate
>> in collapse range to the file system, and ensure that i_size is
>> not going to change.
>>
>> Signed-off-by: Xing Gu <gux.fnst@cn.fujitsu.com>
>
> Does the test really need 3 minutes?
Actually, this case can easily reproduce the issue below 30s.
>
> We can't keep adding tests that take minutes to *maybe* hit a
> regression. This isn't even testing a regression - the
> COLLAPSE_RANGE feature was introduced in 3.15-rc1 and this bug fixed
> in 3.15-rc3, so there are no kernels out there that have this
> bug in them.
>
> IOWs, I really don't think we should be the runtime of a typical
> test cycle by 5% to exercise this non-bug. Maybe 30s at most, but a
> shorter, directly targeted test would be better.
>
> And FWIW, there's nothing ext4 specific about this test - it should
> be in the generic group if we are going to add it.
Indeed, it's not ext4 specific.
What about modifying this case according to Lukas's comment?
Thanks!
Regards,
Xing Gu
>
> Cheers,
>
> Dave.
>
next prev parent reply other threads:[~2014-06-25 10:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 5:50 [PATCH] xfstests: add test for ext4 fallocate collapse range check Xing Gu
2014-06-19 6:56 ` Dave Chinner
2014-06-25 10:05 ` gux.fnst [this message]
2014-06-19 9:12 ` Lukáš Czerner
2014-06-25 10:05 ` gux.fnst
2014-09-17 10:03 ` [PATCH v2] xfstests: add test for truncate/collapse range race Xing Gu
2014-09-25 3:55 ` Eryu Guan
2014-09-30 9:50 ` [PATCH v3] " Xing Gu
2014-10-22 9:56 ` gux.fnst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AA9EDE.8020001@cn.fujitsu.com \
--to=gux.fnst@cn.fujitsu.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=lczerner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox