* Re: xfstests and linux nfs testing [not found] <54368292.8060209@Netapp.com> @ 2014-10-09 16:21 ` Christoph Hellwig 2014-10-09 17:36 ` Anna Schumaker 0 siblings, 1 reply; 2+ messages in thread From: Christoph Hellwig @ 2014-10-09 16:21 UTC (permalink / raw) To: Anna Schumaker Cc: Steve French, linux-nfs@vger.kernel.org, linux-fsdevel, fstests, Lukas Czerner On Thu, Oct 09, 2014 at 08:41:54AM -0400, Anna Schumaker wrote: > I think this is a bug in xfstests. This fixes it for me, but I'm not sure what needs to be checked in the NFS case: Lukas broke this with: common: Check fs consistency on TEST_DEV only when needed as far as I can tell it blindly copied the _require_scratch code to _require_test, which is bad for two reasons: a) due to lots of code duplication b) because it broke filesystems that don't support a scratch dev like nfs. Anna fix should work, can you resend it to the fstests lists with a proper signoff? Even better would be some validation that the passed in "device" is a valid format for a nfs export, but that's not strictly required. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: xfstests and linux nfs testing 2014-10-09 16:21 ` xfstests and linux nfs testing Christoph Hellwig @ 2014-10-09 17:36 ` Anna Schumaker 0 siblings, 0 replies; 2+ messages in thread From: Anna Schumaker @ 2014-10-09 17:36 UTC (permalink / raw) To: Christoph Hellwig Cc: Steve French, linux-nfs@vger.kernel.org, linux-fsdevel, fstests, Lukas Czerner On 10/09/14 12:21, Christoph Hellwig wrote: > On Thu, Oct 09, 2014 at 08:41:54AM -0400, Anna Schumaker wrote: >> I think this is a bug in xfstests. This fixes it for me, but I'm not sure what needs to be checked in the NFS case: > > Lukas broke this with: > common: Check fs consistency on TEST_DEV only when needed > > as far as I can tell it blindly copied the _require_scratch code > to _require_test, which is bad for two reasons: > > a) due to lots of code duplication > b) because it broke filesystems that don't support a scratch dev > like nfs. > > Anna fix should work, can you resend it to the fstests lists with a > proper signoff? Even better would be some validation that the > passed in "device" is a valid format for a nfs export, but that's not > strictly required. Sure! I'll fix up the patch so it doesn't have commented out lines while I'm at it :). I'll take a stab at server format validation, and then send something out! Anna > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-09 17:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <54368292.8060209@Netapp.com>
2014-10-09 16:21 ` xfstests and linux nfs testing Christoph Hellwig
2014-10-09 17:36 ` Anna Schumaker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox