From: Eric Sandeen <sandeen@sandeen.net>
To: Eryu Guan <eguan@redhat.com>, fstests@vger.kernel.org
Subject: Re: [PATCH 1/4] new: fix template for new case to use a single tab not four spaces
Date: Wed, 11 Mar 2015 09:59:33 -0400 [thread overview]
Message-ID: <55004A45.7010002@sandeen.net> (raw)
In-Reply-To: <1426072534-12246-2-git-send-email-eguan@redhat.com>
On 3/11/15 7:15 AM, Eryu Guan wrote:
> So we have preferred code style for all new test cases.
Sure, makes sense.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> new | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/new b/new
> index 86f9075..d1f8939 100755
> --- a/new
> +++ b/new
> @@ -148,8 +148,8 @@ trap "_cleanup; exit \\\$status" 0 1 2 3 15
>
> _cleanup()
> {
> - cd /
> - rm -f \$tmp.*
> + cd /
> + rm -f \$tmp.*
> }
>
> # get standard environment, filters and checks
>
next prev parent reply other threads:[~2015-03-11 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 11:15 [PATCH 0/4] some random small fixes Eryu Guan
2015-03-11 11:15 ` [PATCH 1/4] new: fix template for new case to use a single tab not four spaces Eryu Guan
2015-03-11 13:59 ` Eric Sandeen [this message]
2015-03-11 11:15 ` [PATCH 2/4] generic/027: discard mkdir error message Eryu Guan
2015-03-11 14:08 ` Eric Sandeen
2015-03-11 11:15 ` [PATCH 3/4] common: append -d option to XFS_COPY_PROG when testing v5 xfs Eryu Guan
2015-03-11 14:48 ` Eric Sandeen
2015-03-11 14:52 ` Eric Sandeen
2015-03-12 5:57 ` Eryu Guan
2015-03-11 11:15 ` [PATCH 4/4] xfs/073: be quiet about mouting with nouuid option Eryu Guan
2015-03-11 14:51 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55004A45.7010002@sandeen.net \
--to=sandeen@sandeen.net \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox