FS/XFS testing framework
 help / color / mirror / Atom feed
From: Boaz Harrosh <openosd@gmail.com>
To: Boaz Harrosh <boaz@plexistor.com>, Eryu Guan <eguan@redhat.com>,
	Dave Chinner <david@fromorbit.com>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	fstests@vger.kernel.org
Subject: Re: [PATCH v3] xfstest: generic/080 test that mmap-write updates c/mtime
Date: Thu, 19 Mar 2015 13:49:24 +0200	[thread overview]
Message-ID: <550AB7C4.8040302@gmail.com> (raw)
In-Reply-To: <550AB720.3090009@plexistor.com>

On 03/19/2015 01:46 PM, Boaz Harrosh wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> when using mmap() for file i/o, writing to the file should update
> it's c/mtime. Specifically if we first mmap-read from a page, then
> memap-write to the same page.
> 
> This test was failing for the initial submission of DAX because
> pfn based mapping do not have an page_mkwrite called for them.
> The new Kernel patches that introduce pfn_mkwrite fixes this test.
> 
> Written by Dave Chinner but edited and tested by:
> 	Omer Zilberberg
> 
> Dave hands-up man, it looks like you edited this directly
> in the email, but there was not even a single typo.
> 
> Tested-by: Omer Zilberberg <omzg@plexistor.com>
> Tested-by: Boaz Harrosh <boaz@plexistor.com>
> Signed-off-by: Omer Zilberberg <omzg@plexistor.com>
> Signed-off-by: Boaz Harrosh <boaz@plexistor.com>
> Need-Reviewed-by: Eryu Guan <eguan@redhat.com>

Hi Eryu

Thank you for your review.

I have tried to incorporate your comments, I hope its what you meant.

Thanks
Boaz


  reply	other threads:[~2015-03-19 11:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <54F733BD.7060807@plexistor.com>
     [not found] ` <54F734C4.7080409@plexistor.com>
     [not found]   ` <20150305001312.GA4251@dastard>
     [not found]     ` <54F861F3.9000805@plexistor.com>
2015-03-05 14:12       ` [PATCH 1/3 v2] xfstest: generic/080 test that mmap-write updates c/mtime Boaz Harrosh
2015-03-19  9:53     ` [PATCH 1/3 v2 resend] " Boaz Harrosh
2015-03-19 10:44       ` Eryu Guan
2015-03-19 11:46         ` [PATCH v3] " Boaz Harrosh
2015-03-19 11:49           ` Boaz Harrosh [this message]
2015-03-19 15:30           ` Eryu Guan
2015-03-19 15:58             ` [PATCH v4] " Boaz Harrosh
2015-03-19 16:02             ` [PATCH v3] " Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550AB7C4.8040302@gmail.com \
    --to=openosd@gmail.com \
    --cc=boaz@plexistor.com \
    --cc=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=matthew.r.wilcox@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox