From: Eric Sandeen <sandeen@sandeen.net>
To: Omer Zilberberg <omzg@plexistor.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] _require_command: fixed typo
Date: Thu, 07 May 2015 11:09:35 -0500 [thread overview]
Message-ID: <554B8E3F.6030608@sandeen.net> (raw)
In-Reply-To: <1431014916-1951-1-git-send-email-omzg@plexistor.com>
On 5/7/15 11:08 AM, Omer Zilberberg wrote:
> fixes 9435b92 common: _require_command needs to handle parameters
>
> Signed-off-by: Omer Zilberberg <omzg@plexistor.com>
Yep, thanks!
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 6ea107e..cd0f3e6 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1299,7 +1299,7 @@ _require_command()
> fi
>
> _command=`echo "$1" | awk '{ print $1 }'`
> - if [ ! -x $command ]; then
> + if [ ! -x $_command ]; then
> _notrun "$_name utility required, skipped this test"
> fi
> }
>
next prev parent reply other threads:[~2015-05-07 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 16:08 [PATCH] _require_command: fixed typo Omer Zilberberg
2015-05-07 16:09 ` Eric Sandeen [this message]
2015-05-18 8:16 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B8E3F.6030608@sandeen.net \
--to=sandeen@sandeen.net \
--cc=fstests@vger.kernel.org \
--cc=omzg@plexistor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox