From: Eric Sandeen <sandeen@sandeen.net>
To: Eryu Guan <eguan@redhat.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfs_repair: test for false positive reserved attr name use
Date: Thu, 14 May 2015 09:23:51 -0500 [thread overview]
Message-ID: <5554AFF7.9040702@sandeen.net> (raw)
In-Reply-To: <20150514054450.GD1140@dhcp-13-216.nay.redhat.com>
On 5/14/15 12:44 AM, Eryu Guan wrote:
> On Thu, May 14, 2015 at 12:23:14AM -0500, Eric Sandeen wrote:
>> All good advice; sigh, I am rusty! Thanks, will resend with fixes.
>>
>> (Started as using test dev so left some things out; not sure I need a trap if there is nothing to clean up? Also do we need to require attr on xfs? Can't remember if we can compile that out, but I guess it's harmless to include it)
>
> I did a "grep _require_attrs tests/xfs/*" and result showed several
> tests in xfs require attrs. At least it checks if ATTR_PROG exists :)
Yes, I forgot about that ;(
> And I think we need a trap and cleanup even if there's no obvious things
> to clean, some functions use $tmp.xxx internally, a cleanup could remove
> all these tmp files too, and trap plays with exit status, so it's still
> needed.
Fair enough, thanks for the review.
-Eric
next prev parent reply other threads:[~2015-05-14 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 3:22 [PATCH] xfs_repair: test for false positive reserved attr name use Eric Sandeen
2015-05-14 4:55 ` Eryu Guan
2015-05-14 5:23 ` Eric Sandeen
2015-05-14 5:44 ` Eryu Guan
2015-05-14 14:23 ` Eric Sandeen [this message]
2015-05-14 14:30 ` [PATCH V2] " Eric Sandeen
2015-05-15 6:29 ` Eryu Guan
2015-05-15 14:23 ` [PATCH V3] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5554AFF7.9040702@sandeen.net \
--to=sandeen@sandeen.net \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox