Re: [PATCH] generic/135: fix standard error output from _scratch_mkfs

[Xiao Yang <yangx.jy@cn.fujitsu.com>]

于 2016/02/22 17:40, Zirong Lang 写道:
> 2016年2月22日 14:12，"Xiao Yang"<yangx.jy@cn.fujitsu.com>写道：
>>
>>> 2016年2月22日 11:41，"Xiao Yang"<yangx.jy@cn.fujitsu.com>  写道：
>>>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>>>> ---
>>>>   tests/generic/135 |    2 +-
>>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/tests/generic/135 b/tests/generic/135
>>>> index 52418f6..5aa880d 100755
>>>> --- a/tests/generic/135
>>>> +++ b/tests/generic/135
>>>> @@ -41,7 +41,7 @@ _supported_os Linux IRIX
>>>>
>>>>   _require_odirect
>>>>   _require_scratch
>>>> -_scratch_mkfs>/dev/null
>>>> +_scratch_mkfs&>/dev/null
>>> Hi,
>>>
>>> Although I'm not the offical reviewer, but I think that stderr output can help us to find mkfs failure from golden image diff. So keep the stderr output maybe better.
>>>
>>> If you think your patch is necessary, you'd better give a appropriate reason to explain why we need to ignore that stderr output?
>>>
>>> Thanks,
>>> Zorro
>> mkfs succees with unexpected message when running generic/135, i.e.
>> [root@localhost ~]# mkfs.ext4 /dev/sdb1>/dev/null
>> mke2fs 1.42.9 (28-Dec-2013)
> Hi xiao,
>
> Now I understand what you mean, and I can reproduce that problem. This
> is a regression bug which bring in by commit:
>
> 4a5cda8 xfstests: do not unmount tmpfs during remount
>
> That patch remove "2>&1". I think that is a miss, so you can simply bring
> that back. After you explain the reason in your commit message clearly, I
> think maintainer will glad to check it:)
>
> Thanks,
> Zorro
>
thanks for your suggestion, I will expalin the reason in my commit 
message clearly.
thanks,
xiao yang
>> thanks,
>> xiao yang
>>
>>>>   _scratch_mount
>>>>
>>>>   cd $SCRATCH_MNT
>>>> --
>>>> 1.7.1
>>>>
>>>>
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>
> .
>