Re: [PATCH] fstests: xfs: add necessary version check for xfs/122

Xiaoguang Wang
2016-04-27T05:16:20Z

hello,

On 03/23/2016 06:56 AM, Dave Chinner wrote:
> On Mon, Mar 21, 2016 at 04:31:28PM +0800, Xiaoguang Wang wrote:
>> From: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
>>
>> Since commit c0cfa5651f2d ("xfs/122: update against xfsprogs 4.3"), xfs/122
>> has been updated against xfsprogs 4.3, so add necessary version check.
>>
>> Signed-off-by: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
>
> This sort of version test belongs in autoconf, not the tests
> themselves.
Would you please give me some hints about how to add version test
in autoconf, also in xfs/188, I see similar usage:
if [ $XFSPROGS_VERSION -lt 21000 ]; then
_notrun "this test requires case-insensitive support"
fi

Regards,
Xiaoguang Wang

>
> Cheers,
>
> Dave.
>