From: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
To: fstests@vger.kernel.org
Subject: Re: [PATCH v2] geceric/362: check truncate can update file size correctly when truncate fails
Date: Fri, 1 Jul 2016 09:25:04 +0800 [thread overview]
Message-ID: <5775C670.3060502@cn.fujitsu.com> (raw)
In-Reply-To: <20160630135237.GG23649@eguan.usersys.redhat.com>
hello,
On 06/30/2016 09:52 PM, Eryu Guan wrote:
> On Thu, Jun 30, 2016 at 04:25:49PM +0800, Wang Xiaoguang wrote:
>> In btrfs, when truncate operation fails for enospc reason, file may still
>> have some disk blocks, but it will fail to update filesize accordingly.
>>
>> Kernel commit c0d2f61 has fixed this bug for btrfs:
>> btrfs: fix disk_i_size update bug when ftruncate() fails
>>
>> Signed-off-by: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
>> ---
>> v2: move this test to generic test and add comments why testcase
>> use reflink.
> Thanks for the updated version. Did it fail for you when testing on
> unpatched kernel? I ran the test more than 10 times on 4.6 kernel (which
> doesn't have the fix) and all passed, as well as RHEL7 kernel.
>
> Can you please confirm?
OK, please wait a while :)
Regards,
Xiaoguang Wang
>
> Thanks,
> Eryu
>
>
next prev parent reply other threads:[~2016-07-01 1:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 7:36 [PATCH] btrfs: check truncate can update file size correctly when truncate fails Wang Xiaoguang
2016-06-23 8:27 ` Eryu Guan
2016-06-29 3:22 ` Wang Xiaoguang
2016-06-30 8:25 ` [PATCH v2] geceric/362: " Wang Xiaoguang
2016-06-30 13:52 ` Eryu Guan
2016-07-01 1:25 ` Wang Xiaoguang [this message]
2016-07-01 2:28 ` Wang Xiaoguang
2016-07-01 2:55 ` Eryu Guan
2016-07-01 7:05 ` Wang Xiaoguang
2016-07-01 7:32 ` Eryu Guan
2016-06-23 9:15 ` [PATCH] btrfs: " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5775C670.3060502@cn.fujitsu.com \
--to=wangxg.fnst@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox