From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: fstests@vger.kernel.org
Cc: jtulak@redhat.com
Subject: Re: [PATCH] xfs/191: skip tests on older xfsprogs
Date: Wed, 17 Aug 2016 11:08:44 +0800 [thread overview]
Message-ID: <57B3D53C.2080605@cn.fujitsu.com> (raw)
In-Reply-To: <1471181701-23877-1-git-send-email-yangx.jy@cn.fujitsu.com>
Sorry, please ingore it, I will resend it.
On 2016/08/14 21:35, Xiao Yang wrote:
> From: root <root@localhost.localdomain>
>
> If we don't have /tmp/foo file on xfsprogs 3.2.2, _require_xfs_mkfs_validation
> will fail because mkfs.xfs can't create this file. We need to skip tests
> before xfsprogs 4.7.0, so fix it. the feature has been introduced since
> xfsprogs 4.2.0:
> commit 20cec860e16b267ea0c71a2f648fa2b26aad2e65
> Author: Eric Sandeen <sandeen@sandeen.net>
> Date: Fri Jul 31 09:04:11 2015 +1000
>
> mkfs.xfs: always use underlying fs sector size when mkfs'ing a file
>
> Signed-off-by: root <root@localhost.localdomain>
> ---
> common/rc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/common/rc b/common/rc
> index b19b698..db99794 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3889,6 +3889,9 @@ _get_fs_sysfs_attr()
> # number of failed cases.
> _mkfs_validation_check()
> {
> + if [ ! -f /tmp/foo ]; then
> + touch /tmp/foo
> + fi
> local cmd="$MKFS_XFS_PROG -f -N -d file,name=/tmp/foo,size=$((1024 * 1024 * 1024))"
> $cmd -s size=2s >/dev/null 2>&1
> local sum=$?
next prev parent reply other threads:[~2016-08-17 3:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-14 13:35 [PATCH] xfs/191: skip tests on older xfsprogs Xiao Yang
2016-08-17 3:08 ` Xiao Yang [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-08-17 3:18 Xiao Yang
2016-08-17 3:36 ` Eryu Guan
2016-08-17 9:27 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B3D53C.2080605@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
--cc=jtulak@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox