From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] generic/159: record error value correctly References: <20160830035114.13876-1-wangxg.fnst@cn.fujitsu.com> <20160830035940.GJ27776@eguan.usersys.redhat.com> <57C504EC.5070303@cn.fujitsu.com> <20160830044507.GG8265@birch.djwong.org> From: Wang Xiaoguang Message-ID: <57C51A41.8030806@cn.fujitsu.com> Date: Tue, 30 Aug 2016 13:31:45 +0800 MIME-Version: 1.0 In-Reply-To: <20160830044507.GG8265@birch.djwong.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit To: "Darrick J. Wong" Cc: Eryu Guan , fstests@vger.kernel.org, linux-btrfs@vger.kernel.org List-ID: hello, On 08/30/2016 12:45 PM, Darrick J. Wong wrote: > On Tue, Aug 30, 2016 at 12:00:44PM +0800, Wang Xiaoguang wrote: >> Hi, >> >> On 08/30/2016 11:59 AM, Eryu Guan wrote: >>> On Tue, Aug 30, 2016 at 11:51:14AM +0800, Wang Xiaoguang wrote: >>>> This case failed in btrfs, it's because when trying to open an immutable >>>> file, vfs returns EPERM, not EACCESS, fix this. >>>> >>>> Signed-off-by: Wang Xiaoguang >>>> --- >>>> tests/generic/159.out | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/tests/generic/159.out b/tests/generic/159.out >>>> index 92fe33a..3e5e47f 100755 >>>> --- a/tests/generic/159.out >>>> +++ b/tests/generic/159.out >>>> @@ -2,4 +2,4 @@ QA output created by 159 >>>> Format and mount >>>> Create the original files >>>> Try reflink on immutable files >>>> -TEST_DIR/test-159/file2: Permission denied >>>> +TEST_DIR/test-159/file2: Operation not permitted >>> I think you need to do a filter in the test not change the golden image, >>> so older kernels won't fail because they still return EACCES on >>> immutable inodes. >> I just checked the upstream kernel, found that it retuns EPERM. >> OK, I'll send a new version. > I'm pretty sure "generic/159, 160: deal with EACCESS -> EPERM transition" > already covers this. Yes, it works, thanks. Regards, Xiaoguang Wang > > --D > >> Regards, >> Xiaoguang Wang >> >>> Thanks, >>> Eryu >>> >>> >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe fstests" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >