Re: [PATCH v1] xfstests: filter the default EA

[Xiaoli Feng <xifeng@redhat.com>]

Hello,

----- Original Message -----
> From: "Steve French" <smfrench@gmail.com>
> To: "Xiaoli Feng" <xifeng@redhat.com>
> Cc: "Christoph Hellwig" <hch@infradead.org>, fstests@vger.kernel.org, "Ronnie Sahlberg" <lsahlber@redhat.com>, "CIFS"
> <linux-cifs@vger.kernel.org>
> Sent: Thursday, December 20, 2018 11:53:09 AM
> Subject: Re: [PATCH v1] xfstests: filter the default EA
> 
> What server type (presumably Samba if mounting to localhost)?  What

Yes, it's Samba.

> dialect (if RHEL since it is older it would default to cifs with posix
> extensions, if kernel from last few years would default to smb3.02
> dialect)?

The dialect is smb3.02.

> 
> What does the getfattr on the local path show as the attributes?

It shows nothing for local path on xfs filesystem.

# touch /file
# getfattr /file
#

> 
> On Wed, Dec 19, 2018 at 9:03 PM Xiaoli Feng <xifeng@redhat.com> wrote:
> >
> > Hi Steve,
> >
> > ----- Original Message -----
> > > From: "Steve French" <smfrench@gmail.com>
> > > To: "Xiaoli Feng" <xifeng@redhat.com>
> > > Cc: "Christoph Hellwig" <hch@infradead.org>, fstests@vger.kernel.org,
> > > "Ronnie Sahlberg" <lsahlber@redhat.com>,
> > > "sprabhu" <sprabhu@redhat.co>, "CIFS" <linux-cifs@vger.kernel.org>
> > > Sent: Thursday, December 20, 2018 10:24:26 AM
> > > Subject: Re: [PATCH v1] xfstests: filter the default EA
> > >
> > > On Wed, Dec 19, 2018 at 8:17 PM Xiaoli Feng <xifeng@redhat.com> wrote:
> > > >
> > > > Hi Christoph,
> > > >
> > > > ----- Original Message -----
> > > > > From: "Christoph Hellwig" <hch@infradead.org>
> > > > > To: "XiaoLi Feng" <xifeng@redhat.com>
> > > > > Cc: fstests@vger.kernel.org
> > > > > Sent: Wednesday, December 19, 2018 3:18:34 PM
> > > > > Subject: Re: [PATCH v1] xfstests: filter the default EA
> > > > >
> > > > > On Wed, Dec 19, 2018 at 11:44:28AM +0800, XiaoLi Feng wrote:
> > > > > > From: xiaoli feng <xifeng@redhat.com>
> > > > > >
> > > > > > For some filesystems, such as CIFS, the file or directory has the
> > > > > > default extend attribute. It makes these tests generic/020
> > > > > > generic/337 generic/377 failed. Now add this patch to filter the
> > > > > > default EA.
> > > > >
> > > > > What is "the default EA"?  This sounds like a CIFS bug to me.
> > > >
> > > > the default EA means the new file or directory has extended attributes.
> > > >
> > > > # touch cifs/file
> > > > # getfattr cifs/file
> > > > # file: cifs/file
> > > > user.security.selinux
> > >
> > > user.security.selinux is not a cifs EA.  This "default EA" is not
> > > handled/returned by CIFS.
> > >
> > > cifs.ko can save/return new EAs set by the user and even return a
> > > couple pseudo-EAs (cifs.dosattrib for example) if that EA is queried
> > > explicitly in order to return metadata (important flags needed for
> > > backup etc.) - but this "user.security.selinux" "default EA" is not
> > > returned by the cifs.ko code.
> >
> > # getfattr ~/cifs
> > # mount //localhost/cifs ~/cifs -o user=root,password=redhat
> > # getfattr ~/cifs
> > getfattr: Removing leading '/' from absolute path names
> > # file: root/cifs
> > user.security.selinux
> >
> > After mount the cifs share, the mountpoint ~/cifs already has "
> > user.security.selinux" extended attributes. I don't know who add it.
> >
> >
> > >
> > >
> > > --
> > > Thanks,
> > >
> > > Steve
> > >
> 
> 
> 
> --
> Thanks,
> 
> Steve
>