FS/XFS testing framework
 help / color / mirror / Atom feed
From: Mark Harmstone <maharmstone@meta.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"neelx@suse.com" <neelx@suse.com>,
	"Johannes.Thumschirn@wdc.com" <Johannes.Thumschirn@wdc.com>,
	Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH v3 2/2] btrfs: add test for encoded reads
Date: Mon, 6 Jan 2025 12:22:14 +0000	[thread overview]
Message-ID: <587c35b8-eb77-49e2-8979-37a5a3a31427@meta.com> (raw)
In-Reply-To: <174a47bc-2ff4-455a-897d-39316352d444@oracle.com>

On 6/1/25 02:25, Anand Jain wrote:
>>> +
>>> +_scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed"
>>> +sector_size=$(_scratch_btrfs_sectorsize)
>>> +
>>> +if [[ $sector_size -ne 4096 && $sector_size -ne 65536 ]]; then
>>> +    _notrun "sector size $sector_size not supported by this test"
>>> +fi
>>> +
> 
> _require_btrfs_support_sectorsize <xx>
> 

All the rest looks good, but this isn't right. 
_require_btrfs_support_sectorsize tests for kernel support, I'm just 
accounting for the fact I've only written the test for 4k and 64k sector 
sizes.

I'll move this bit to the if statement that follows, to make it clearer 
what I'm doing.

Mark

  reply	other threads:[~2025-01-06 12:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 14:55 [PATCH v3 1/2] configure: use pkg-config to find liburing Mark Harmstone
2024-12-19 14:55 ` [PATCH v3 2/2] btrfs: add test for encoded reads Mark Harmstone
2025-01-03 16:13   ` Josef Bacik
2025-01-06  2:25     ` Anand Jain
2025-01-06 12:22       ` Mark Harmstone [this message]
2025-01-03 16:13 ` [PATCH v3 1/2] configure: use pkg-config to find liburing Josef Bacik
2025-01-06  2:44 ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=587c35b8-eb77-49e2-8979-37a5a3a31427@meta.com \
    --to=maharmstone@meta.com \
    --cc=Johannes.Thumschirn@wdc.com \
    --cc=anand.jain@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=neelx@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox