From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from cn.fujitsu.com ([59.151.112.132]:2351 "EHLO
        heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1750949AbdEPI0w (ORCPT
        <rfc822;fstests@vger.kernel.org>); Tue, 16 May 2017 04:26:52 -0400
Message-ID: <591AB7C8.2070100@cn.fujitsu.com>
Date: Tue, 16 May 2017 16:26:48 +0800
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
MIME-Version: 1.0
Subject: Re: [PATCH] build: workaround build failures with old autoconf version
References: <20170516075832.4612-1-eguan@redhat.com>
In-Reply-To: <20170516075832.4612-1-eguan@redhat.com>
Content-Type: text/plain; charset="GB2312"
Content-Transfer-Encoding: 7bit
Sender: fstests-owner@vger.kernel.org
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, gwendal@chromium.org
List-ID: <fstests@vger.kernel.org>

On 2017/05/16 15:58, Eryu Guan wrote:
> Xiao Yang reported that fstests failed to build on RHEL6.9 hosts due
> to old autoreconf didn't pass -I to aclocal -I. This was fixed by
> autoconf commit 44fbeef86d03 ("Pass autoreconf -I to aclocal -I").
>
> So call aclocal, autoheader and autoconf directly instead of
> autoreconf, as what's done in xfsprogs Makefile.
>
> Also add include/config.h.in to CONFIGURE, which is generated by
> autoheader,  so it also gets removed by make realclean.
>
> Reported-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
>
> Hi Xiao Yang, can you please this patch on your RHEL6 host? It works for me.
Hi Eryu

It looks fine and works normally on my RHEL6 host.

Thanks
Xiao Yang
> Hi Gwendal, can you please test if cross-compilation still works for chromeOS?
> I don't have the chromeOS environment to test.. Thanks!
>
>  Makefile | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index ebf5c03..dd8d344 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -41,7 +41,7 @@ endif
>  
>  SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz
>  
> -CONFIGURE = configure include/builddefs include/config.h \
> +CONFIGURE = configure include/builddefs include/config.h include/config.h.in \
>  	    aclocal.m4 config.guess config.sub install-sh ltmain.sh \
>  	    m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 \
>  	    m4/lt~obsolete.m4
> @@ -79,8 +79,10 @@ clean:  # if configure hasn't run, nothing to clean
>  endif
>  
>  configure: configure.ac
> -	autoreconf --include=m4
> -	libtoolize -i
> +	libtoolize -cfi
> +	aclocal -I m4
> +	autoheader
> +	autoconf
>  
>  include/builddefs include/config.h: configure
>  	./configure \