From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cn.fujitsu.com ([59.151.112.132]:62175 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S941832AbdEYEvZ (ORCPT ); Thu, 25 May 2017 00:51:25 -0400 Message-ID: <592662C5.8060705@cn.fujitsu.com> Date: Thu, 25 May 2017 12:51:17 +0800 From: Xiao Yang MIME-Version: 1.0 Subject: Re: [PATCH] build: workaround build failures with old autoconf version References: <20170516075832.4612-1-eguan@redhat.com> <591AB7C8.2070100@cn.fujitsu.com> <20170525040836.GC23805@eguan.usersys.redhat.com> In-Reply-To: <20170525040836.GC23805@eguan.usersys.redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: gwendal@chromium.org, fstests@vger.kernel.org List-ID: On 2017/05/25 12:08, Eryu Guan wrote: > On Tue, May 16, 2017 at 04:26:48PM +0800, Xiao Yang wrote: >> On 2017/05/16 15:58, Eryu Guan wrote: >>> Xiao Yang reported that fstests failed to build on RHEL6.9 hosts due >>> to old autoreconf didn't pass -I to aclocal -I. This was fixed by >>> autoconf commit 44fbeef86d03 ("Pass autoreconf -I to aclocal -I"). >>> >>> So call aclocal, autoheader and autoconf directly instead of >>> autoreconf, as what's done in xfsprogs Makefile. >>> >>> Also add include/config.h.in to CONFIGURE, which is generated by >>> autoheader, so it also gets removed by make realclean. >>> >>> Reported-by: Xiao Yang >>> Signed-off-by: Eryu Guan >>> --- >>> >>> Hi Xiao Yang, can you please this patch on your RHEL6 host? It works for me. >> Hi Eryu >> >> It looks fine and works normally on my RHEL6 host. > Thanks for testing! Can you provide a "Reviewed-by"? Hi Eryu Yeah, this looks good to me. Reviewed-by: Xiao Yang Thanks, Xiao Yang. > Gwendal, could you please help check if cross-compiling chromeOS still > works after this patch? Thanks a lot! > > Eryu > >> Thanks >> Xiao Yang >>> Hi Gwendal, can you please test if cross-compilation still works for chromeOS? >>> I don't have the chromeOS environment to test.. Thanks! >>> >>> Makefile | 8 +++++--- >>> 1 file changed, 5 insertions(+), 3 deletions(-) >>> >>> diff --git a/Makefile b/Makefile >>> index ebf5c03..dd8d344 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -41,7 +41,7 @@ endif >>> >>> SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz >>> >>> -CONFIGURE = configure include/builddefs include/config.h \ >>> +CONFIGURE = configure include/builddefs include/config.h include/config.h.in \ >>> aclocal.m4 config.guess config.sub install-sh ltmain.sh \ >>> m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 \ >>> m4/lt~obsolete.m4 >>> @@ -79,8 +79,10 @@ clean: # if configure hasn't run, nothing to clean >>> endif >>> >>> configure: configure.ac >>> - autoreconf --include=m4 >>> - libtoolize -i >>> + libtoolize -cfi >>> + aclocal -I m4 >>> + autoheader >>> + autoconf >>> >>> include/builddefs include/config.h: configure >>> ./configure \ >> >> > > . >