From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: "\"Ernesto A. Fernández\"" <ernesto.mnd.fernandez@gmail.com>
Cc: fstests@vger.kernel.org, Eryu Guan <eguan@redhat.com>
Subject: Re: [PATCH] generic/449: remove unused _require_test
Date: Mon, 31 Jul 2017 11:38:43 +0800 [thread overview]
Message-ID: <597EA643.3020905@cn.fujitsu.com> (raw)
In-Reply-To: <20170730032727.GA4836@debian.home>
On 2017/07/30 11:27, Ernesto A. Fernández wrote:
> On Mon, Jul 24, 2017 at 02:57:38PM +0800, Xiao Yang wrote:
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>> _supported_fs generic
>> _supported_os Linux
>> _require_scratch
>> -_require_test
>> _require_acls
>> _require_attrs
> Hi, I wrote that test, thank you for taking the time to review it.
>
> It would seem that _require_acls uses the test device, things could get
> weird if it's not there.
>
>
Hi Ernesto A and Eryu,
init_rc() have checked if TEST_DEV existed and was mounted, and we
introduced _require_test to check
file system consistency on TEST_DEV after running tests. I think it's
not necessary to add _require_test.
I'm not sure about it, so cc Eryu to confirm it.
Thanks,
Xiao Yang.
next prev parent reply other threads:[~2017-07-31 3:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 6:57 [PATCH] generic/449: remove unused _require_test Xiao Yang
2017-07-30 3:27 ` Ernesto A. Fernández
2017-07-31 3:38 ` Xiao Yang [this message]
2017-07-31 4:59 ` Ernesto A. Fernández
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=597EA643.3020905@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=eguan@redhat.com \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox