Re: [PATCH v2 2/2] xfs: Regression test for invalid sb_logsunit

Dave Chinner
2018-01-12T08:36:23Z

On Fri, Jan 12, 2018 at 03:49:21PM +0800, Eryu Guan wrote:
> On Fri, Jan 12, 2018 at 02:16:23PM +0800, xiao yang wrote:
> > If log stripe unit isn't a multiple of the fs blocksize and mounting,
> > the invalid sb_logsunit leads to crash as soon as we try to write to
> > the log.
> >
> > Signed-off-by: xiao yang <yangx.jy@cn.fujitsu.com>
> > ---
> > tests/xfs/437 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > tests/xfs/437.out | 2 ++
> > tests/xfs/group | 1 +
> > 3 files changed, 76 insertions(+)
> > create mode 100755 tests/xfs/437
> > create mode 100644 tests/xfs/437.out
> >
> > diff --git a/tests/xfs/437 b/tests/xfs/437
> > new file mode 100755
> > index 0000000..f2b84ad
> > --- /dev/null
> > +++ b/tests/xfs/437
> > @@ -0,0 +1,73 @@
> > +#! /bin/bash
> > +# FS QA Test No. 437
> > +#
> > +# Regression test for commit:
> > +# 9c92ee2 ("xfs: validate sb_logsunit is a multiple of the fs blocksize")
> > +#
> > +# If log stripe unit isn't a multiple of the fs blocksize and mounting,
> > +# the invalid sb_logsunit leads to crash as soon as we try to write to
> > +# the log.
> > +#
> > +#-----------------------------------------------------------------------
> > +# Copyright (c) 2018 FUJITSU. All Rights Reserved.
> > +# Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
> > +#
> > +# This program is free software; you can redistribute it and/or
> > +# modify it under the terms of the GNU General Public License as
> > +# published by the Free Software Foundation.
> > +#
> > +# This program is distributed in the hope that it would be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > +# GNU General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program; if not, write the Free Software Foundation,
> > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> > +#-----------------------------------------------------------------------
> > +
> > +seq=`basename "$0"`
> > +seqres="$RESULT_DIR/$seq"
> > +echo "QA output created by $seq"
> > +
> > +here=`pwd`
> > +tmp=/tmp/$$
> > +status=1 # failure is the default!
> > +trap "_cleanup; exit \$status" 0 1 2 3 15
> > +
> > +_cleanup()
> > +{
> > + rm -rf $tmp.*
> > +}
> > +
> > +# get standard environment and checks
> > +. ./common/rc
> > +
> > +# real QA test starts here
> > +_supported_os Linux
> > +_supported_fs xfs
> > +_require_scratch
>
> This test triggers ASSERT failure and warning on debug build, thus
> failed _dmesg_check, I think we need _disable_dmesg_check (and some
> comments) too.
>
> [1809960.157615] XFS (sda6): log stripe unit 4095 bytes must be a multiple of block size
> [1809960.159228] XFS (sda6): AAIEEE! Log failed size checks. Abort!
> [1809960.160534] XFS: Assertion failed: 0, file: fs/xfs/xfs_log.c, line: 679
> [1809960.162298] WARNING: CPU: 1 PID: 2186 at fs/xfs/xfs_message.c:105 asswarn+0x1e/0x30 [xfs]

If it triggers debug asserts which have been put there to catch bugs
in other utilities (like mkfs) on a current upstream debug kernel,
then the test should not be part of the auto and quick groups.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com