From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.cn.fujitsu.com ([183.91.158.132]:53304 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751179AbeC2KZ4 (ORCPT ); Thu, 29 Mar 2018 06:25:56 -0400 Message-ID: <5ABCBF30.4060403@cn.fujitsu.com> Date: Thu, 29 Mar 2018 18:25:52 +0800 From: Xiao Yang MIME-Version: 1.0 Subject: Re: [PATCH] common/xfs: don't call xfs_scrub on a block device References: <20180321165716.GB4818@magnolia> <20180322024656.GC4810@magnolia> In-Reply-To: <20180322024656.GC4810@magnolia> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: fstests-owner@vger.kernel.org To: "Darrick J. Wong" Cc: Eryu Guan , fstests List-ID: On 2018/03/22 10:46, Darrick J. Wong wrote: > From: Darrick J. Wong > > xfs_scrub takes an xfs mountpoint as its argument, not a block device. > Therefore, fix _check_xfs_filesystem to call it correctly. Hi Darrick, According to xfs_scrub manpage, it seems that xfs_scrub can take a mounted block device as its argument. Is the xfs_scrub manpage incorrect? Thanks, Xiao Yang > Signed-off-by: Darrick J. Wong > --- > common/xfs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/xfs b/common/xfs > index 5dbd81e..1d98ba1 100644 > --- a/common/xfs > +++ b/common/xfs > @@ -358,7 +358,7 @@ _check_xfs_filesystem() > # Run online scrub if we can. > mntpt="$(_is_dev_mounted $device)" > if [ -n "$mntpt" ]&& _supports_xfs_scrub "$mntpt" "$device"; then > - "$XFS_SCRUB_PROG" $scrubflag -v -d -n $device> $tmp.scrub 2>&1 > + "$XFS_SCRUB_PROG" $scrubflag -v -d -n $mntpt> $tmp.scrub 2>&1 > if [ $? -ne 0 ]; then > _log_err "_check_xfs_filesystem: filesystem on $device failed scrub" > echo "*** xfs_scrub $scrubflag -v -d -n output ***">> $seqres.full > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >