From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Eryu Guan <eguan@linux.alibaba.com>
Cc: <fstests@vger.kernel.org>, <guaneryu@gmail.com>
Subject: Re: [PATCH] ltp/fsx.c: Ignore unsupported keep_size flag even if it's specified by --replay-ops
Date: Mon, 6 Jan 2020 16:29:50 +0800 [thread overview]
Message-ID: <5E12EFFE.8060906@cn.fujitsu.com> (raw)
In-Reply-To: <20200103082642.GE41863@e18g06458.et15sqa>
On 2020/1/3 16:26, Eryu Guan wrote:
> I proposed a similar fix back in 2017[1], but Amir didn't like it
> because my patch (and your patch) ignored keep_size silently (newly
> generated ops list was different than the one fed to --replay-ops).
>
> I proposed a new version in last Oct[2], which will record such ops as
> skipped in the generated ops list, and Brian suggested to add a switch
> to control the behavior if we want to fail fsx on unsupported ops. But I
> didn't have time to work on it since then..
>
> Would you like to help implement the switch Brian suggested based on my
> second patch? Then I can apply my v2 patch& your switch patch.
Hi Eryu,
After reading current fsx code, it will skip all unsupported ops(e.g.
punch_hole, zero_range,
collapse_range) automatically even if they are specified by --replay-ops.
Why do we need to add a switch for keep size?
Thanks,
Xiao Yang
next prev parent reply other threads:[~2020-01-06 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 7:54 [PATCH] ltp/fsx.c: Ignore unsupported keep_size flag even if it's specified by --replay-ops Xiao Yang
2020-01-03 8:26 ` Eryu Guan
2020-01-03 9:10 ` Xiao Yang
2020-01-06 8:29 ` Xiao Yang [this message]
2020-01-06 8:38 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E12EFFE.8060906@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=eguan@linux.alibaba.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox