From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A7FC32771 for ; Mon, 6 Jan 2020 08:39:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F181B21734 for ; Mon, 6 Jan 2020 08:39:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725887AbgAFIjI (ORCPT ); Mon, 6 Jan 2020 03:39:08 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:17858 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725821AbgAFIjI (ORCPT ); Mon, 6 Jan 2020 03:39:08 -0500 X-IronPort-AV: E=Sophos;i="5.69,401,1571673600"; d="scan'208";a="81369100" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 06 Jan 2020 16:39:05 +0800 Received: from G08CNEXMBPEKD06.g08.fujitsu.local (unknown [10.167.33.206]) by cn.fujitsu.com (Postfix) with ESMTP id 9AD6649E9329; Mon, 6 Jan 2020 16:30:03 +0800 (CST) Received: from [10.167.220.69] (10.167.220.69) by G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 6 Jan 2020 16:39:00 +0800 Message-ID: <5E12F222.7090104@cn.fujitsu.com> Date: Mon, 6 Jan 2020 16:38:58 +0800 From: Xiao Yang User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.2; zh-CN; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: Eryu Guan CC: , Subject: Re: [PATCH] ltp/fsx.c: Ignore unsupported keep_size flag even if it's specified by --replay-ops References: <20200103075451.12354-1-yangx.jy@cn.fujitsu.com> <20200103082642.GE41863@e18g06458.et15sqa> <5E12EFFE.8060906@cn.fujitsu.com> In-Reply-To: <5E12EFFE.8060906@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.220.69] X-ClientProxiedBy: G08CNEXCHPEKD04.g08.fujitsu.local (10.167.33.200) To G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) X-yoursite-MailScanner-ID: 9AD6649E9329.AAB54 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On 2020/1/6 16:29, Xiao Yang wrote: > On 2020/1/3 16:26, Eryu Guan wrote: >> I proposed a similar fix back in 2017[1], but Amir didn't like it >> because my patch (and your patch) ignored keep_size silently (newly >> generated ops list was different than the one fed to --replay-ops). >> >> I proposed a new version in last Oct[2], which will record such ops as >> skipped in the generated ops list, and Brian suggested to add a switch >> to control the behavior if we want to fail fsx on unsupported ops. But I >> didn't have time to work on it since then.. >> >> Would you like to help implement the switch Brian suggested based on my >> second patch? Then I can apply my v2 patch& your switch patch. > Hi Eryu, > > After reading current fsx code, it will skip all unsupported ops(e.g. > punch_hole, zero_range, > collapse_range) automatically even if they are specified by --replay-ops. > > Why do we need to add a switch for keep size? Hi Eryu, Do you mean that we should add a switch for all unsupported ops(punch_hole, zero_range, keep_size and so on)? Thanks, Xiao Yang > > Thanks, > Xiao Yang > > > . >