From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980D0C433E0 for ; Wed, 15 Jul 2020 05:55:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C1D9206D5 for ; Wed, 15 Jul 2020 05:55:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728687AbgGOFzV (ORCPT ); Wed, 15 Jul 2020 01:55:21 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:25190 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725850AbgGOFzU (ORCPT ); Wed, 15 Jul 2020 01:55:20 -0400 X-IronPort-AV: E=Sophos;i="5.75,354,1589212800"; d="scan'208";a="96370245" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 15 Jul 2020 13:55:18 +0800 Received: from G08CNEXMBPEKD06.g08.fujitsu.local (unknown [10.167.33.206]) by cn.fujitsu.com (Postfix) with ESMTP id A3C0B4CE3F1A; Wed, 15 Jul 2020 13:55:15 +0800 (CST) Received: from [10.167.220.69] (10.167.220.69) by G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 15 Jul 2020 13:55:16 +0800 Message-ID: <5F0E9A42.5010807@cn.fujitsu.com> Date: Wed, 15 Jul 2020 13:55:14 +0800 From: Xiao Yang User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.2; zh-CN; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: Ira Weiny CC: , Subject: Re: [PATCH v6 1/7] common/rc: Introduce new helpers for DAX mount options and FS_XFLAG_DAX References: <20200714094009.8654-1-yangx.jy@cn.fujitsu.com> <20200714094009.8654-2-yangx.jy@cn.fujitsu.com> <20200715015935.GG3008823@iweiny-DESK2.sc.intel.com> <5F0E75DE.8050508@cn.fujitsu.com> <20200715041559.GK3008823@iweiny-DESK2.sc.intel.com> In-Reply-To: <20200715041559.GK3008823@iweiny-DESK2.sc.intel.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.220.69] X-ClientProxiedBy: G08CNEXCHPEKD06.g08.fujitsu.local (10.167.33.205) To G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) X-yoursite-MailScanner-ID: A3C0B4CE3F1A.AC9F0 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On 2020/7/15 12:15, Ira Weiny wrote: > On Wed, Jul 15, 2020 at 11:19:58AM +0800, Xiao Yang wrote: >> On 2020/7/15 9:59, Ira Weiny wrote: >>> On Tue, Jul 14, 2020 at 05:40:03PM +0800, Xiao Yang wrote: >>>> 1) _require_scratch_dax_mountopt() checks both old and new DAX mount option >>>> 2) _require_dax_iflag() checks FS_XFLAG_DAX >>>> >>>> Signed-off-by: Xiao Yang >>> Reviewed-by: Ira Weiny >> Hi Ira, >> >> Do you want to check if invalid parameter is passed to >> _require_scratch_dax_mountopt? Thought >> I think it is not necessary(user should pass correct parament). >> Like this: >> [ "$mountopt" != "dax" ]&& [ "$mountopt" != "dax=always" ]&& _notrun >> "$mountopt is invalid" > I thought this patch was just checking if the filesystem/device supported DAX > such that DAX tests could run using either old _or_ new dax support... > But after thinking about it I think we need something more complicated. > > Something like: > > if ('-o dax=inode') > // FS is DAX with per file support (ie ext4 || XFS kernel>= 5.8) Hi Ira, dax=inode/dax=never cannot check if underlying device supports dax, so I perfer to use dax=always For example: XFS: # mount -o dax=inode /dev/sda8 /mnt/xfstests/test/ # mount | grep sda8 /dev/sda8 on /mnt/xfstests/test type xfs (rw,relatime,seclabel,attr2,inode64,logbufs=8,logbsize=32k,noquota) ... # mount -o dax=always /dev/sda8 /mnt/xfstests/test/ # mount | grep sda8 /dev/sda8 on /mnt/xfstests/test type xfs (rw,relatime,seclabel,attr2,dax=never,inode64,logbufs=8,logbsize=32k,noquota) EXT4: # mount -o dax=inode /dev/sda8 /mnt/xfstests/test/ # mount | grep sda8 /dev/sda8 on /mnt/xfstests/test type ext4 (rw,relatime,seclabel,dax=inode) ... # mount -o dax=always /dev/sda8 /mnt/xfstests/test/ mount: /mnt/xfstests/test: wrong fs type, bad option, bad superblock on /dev/sda8, missing codepage or helper program, or other error. # dmesg | grep DAX [597988.165120] EXT4-fs (sda8): DAX unsupported by block device. If we want to test new dax(i.e. dax=inode, dax=always or dax=never), so pass "dax=always" to _require_scratch_dax_mountopt If we want to test old dax or new dax=always(either of them), so pass "dax" to _require_scratch_dax_mountopt Best Regards, Xiao Yang > else if ('-o dax') > // FS is DAX (ie ext4 || XFS on kernel< 5.8) > else > // FS has no dax support. > > Do we do that with 2 functions? > > _require_scratch_dax_mountopt() > _require_scratch_new_dax_mountopt() > > If both fail we are in the else clause above? > > We can use the dax=inode because it is a new option and is not necessarily the > option used while running the tests. (I think. as I said my xfstests skills > are not great so I'm not always sure of the correct patterns) > > Ira > >> Best Regards, >> Xiao Yang >>>> --- >>>> >>>> V5->V6: >>>> Simplify _require_scratch_dax_mountopt because it is enough to only check >>>> dax/dax=always mount option. See the following reasons: >>>> 1) we cannot detect if underlying device supports dax by mounting dax=inode >>>> or dax=never. >>>> 2) dax=always, dax=inode, dax=never are always introduced together. >>>> >>>> common/rc | 22 ++++++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> diff --git a/common/rc b/common/rc >>>> index f17b19f2..aeec1f11 100644 >>>> --- a/common/rc >>>> +++ b/common/rc >>>> @@ -3188,6 +3188,28 @@ _require_scratch_dax() >>>> _scratch_unmount >>>> } >>>> >>>> +# Only accept dax/dax=always mount option becasue dax=always, dax=inode >>>> +# and dax=never are always introduced together. >>>> +_require_scratch_dax_mountopt() >>>> +{ >>>> + local mountopt=$1 >>>> + >>>> + _require_scratch >>>> + _scratch_mkfs> /dev/null 2>&1 >>>> + _try_scratch_mount "-o $mountopt"> /dev/null 2>&1 || \ >>>> + _notrun "mount $SCRATCH_DEV with $mountopt failed" >>>> + >>>> + _fs_options $SCRATCH_DEV | egrep -q "dax(=always|,|$)" || \ >>>> + _notrun "$SCRATCH_DEV $FSTYP does not support -o $mountopt" >>>> + >>>> + _scratch_unmount >>>> +} >>>> + >>>> +_require_dax_iflag() >>>> +{ >>>> + _require_xfs_io_command "chattr" "x" >>>> +} >>>> + >>>> # Does norecovery support by this fs? >>>> _require_norecovery() >>>> { >>>> -- >>>> 2.21.0 >>>> >>>> >>>> >>> . >>> >> >> > > . >