From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Zorro Lang <zlang@redhat.com>
Cc: <fstests@vger.kernel.org>
Subject: Re: [PATCH] generic/611: remove _supported_os line
Date: Tue, 22 Sep 2020 16:49:34 +0800 [thread overview]
Message-ID: <5F69BA9E.7040201@cn.fujitsu.com> (raw)
In-Reply-To: <20200921043144.8057-1-zlang@redhat.com>
On 2020/9/21 12:31, Zorro Lang wrote:
> The current xfstests doesn't support _supported_os() function, the
> generic/611 always hit an error:
>
> xfstests-dev/tests/generic/611: line 39: _supported_os: command not found
>
> So remove the "_supported_os Linux" line directly.
Hi Zorro,
It seems better to add a fix tag:
Fixes: a860a167d87a ("common: kill _supported_os")
Other than that it is fine for me. :-)
Reviewed-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Best Regards,
Xiao Yang
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
> tests/generic/611 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/generic/611 b/tests/generic/611
> index 069db6f9..f4158bb3 100755
> --- a/tests/generic/611
> +++ b/tests/generic/611
> @@ -36,7 +36,6 @@ rm -f $seqres.full
> # real QA test starts here
>
> _supported_fs generic
> -_supported_os Linux
> _require_scratch
> _require_attrs
>
next prev parent reply other threads:[~2020-09-22 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 4:31 [PATCH] generic/611: remove _supported_os line Zorro Lang
2020-09-21 9:00 ` Pavel Reichl
2020-09-22 8:49 ` Xiao Yang [this message]
2020-09-27 9:38 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F69BA9E.7040201@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox