From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: <amir73il@gmail.com>
Cc: Xiao Yang <yangx.jy@cn.fujitsu.com>, <fstests@vger.kernel.org>
Subject: Re: [PATCH] overlay/071: Fix undefined OVL_BASE_SCRATCH_DIR
Date: Wed, 30 Sep 2020 13:32:49 +0800 [thread overview]
Message-ID: <5F741881.5020309@cn.fujitsu.com> (raw)
In-Reply-To: <20200930050409.24705-1-yangx.jy@cn.fujitsu.com>
Hi Amir,
I always got diffenent inode number if underlying fileystem is ext4.
------------------------------------------------
# diff -u /var/lib/xfstests/tests/overlay/071.out
/var/lib/xfstests/results//overlay/071.out.bad
--- /var/lib/xfstests/tests/overlay/071.out 2020-09-30
12:59:30.478968816 +0800
+++ /var/lib/xfstests/results//overlay/071.out.bad 2020-09-30
13:13:02.342920819 +0800
@@ -1,2 +1,26 @@
QA output created by 071
+--- /tmp/25096.lower.lo 2020-09-30 13:12:59.594920981 +0800
++++ /tmp/25096.before.lo 2020-09-30 13:12:59.706920975 +0800
+@@ -1,7 +1,7 @@
+-8590721028 file
+-8590721029 symlink
+-8590721030 link
+-8590721031 chrdev
+-8590721032 blkdev
+-8590721033 fifo
+-8590721034 socket
++9223372045445496836 file
++9223372045445496837 symlink
++9223372045445496838 link
++9223372045445496839 chrdev
++9223372045445496840 blkdev
++9223372045445496841 fifo
++9223372045445496842 socket
+file not found by ino 8590721028 (from /tmp/25096.lower.lo) - see
/var/lib/xfstests/results//overlay/071.full
+symlink not found by ino 8590721029 (from /tmp/25096.lower.lo) - see
/var/lib/xfstests/results//overlay/071.full
+link not found by ino 8590721030 (from /tmp/25096.lower.lo) - see
/var/lib/xfstests/results//overlay/071.full
+chrdev not found by ino 8590721031 (from /tmp/25096.lower.lo) - see
/var/lib/xfstests/results//overlay/071.full
+blkdev not found by ino 8590721032 (from /tmp/25096.lower.lo) - see
/var/lib/xfstests/results//overlay/071.full
+fifo not found by ino 8590721033 (from /tmp/25096.lower.lo) - see
/var/lib/xfstests/results//overlay/071.full
+socket not found by ino 8590721034 (from /tmp/25096.lower.lo) - see
/var/lib/xfstests/results//overlay/071.full
Silence is golde
------------------------------------------------
Is this expected behavior? :-)
Best Regards,
Xiao Yang
On 2020/9/30 13:04, Xiao Yang wrote:
> Replace undefined OVL_BASE_SCRATCH_DIR with OVL_BASE_SCRATCH_MNT
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> tests/overlay/071 | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/overlay/071 b/tests/overlay/071
> index f18429c9..ac2324c8 100755
> --- a/tests/overlay/071
> +++ b/tests/overlay/071
> @@ -59,9 +59,9 @@ lower=$OVL_BASE_TEST_DIR/$OVL_LOWER-$seq
> upper=$OVL_BASE_SCRATCH_MNT/$OVL_UPPER
> work=$OVL_BASE_SCRATCH_MNT/$OVL_WORK
> # Lower dir of nested overlay is the scratch overlay mount at SCRATCH_MNT
> -upper2=$OVL_BASE_SCRATCH_DIR/$OVL_UPPER.2
> -work2=$OVL_BASE_SCRATCH_DIR/$OVL_WORK.2
> -mnt2=$OVL_BASE_SCRATCH_DIR/$OVL_MNT.2
> +upper2=$OVL_BASE_SCRATCH_MNT/$OVL_UPPER.2
> +work2=$OVL_BASE_SCRATCH_MNT/$OVL_WORK.2
> +mnt2=$OVL_BASE_SCRATCH_MNT/$OVL_MNT.2
>
> lowerdir=$lower/lowertestdir
> upperdir=$upper/uppertestdir
next prev parent reply other threads:[~2020-09-30 5:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 5:04 [PATCH] overlay/071: Fix undefined OVL_BASE_SCRATCH_DIR Xiao Yang
2020-09-30 5:32 ` Xiao Yang [this message]
2020-09-30 7:54 ` Amir Goldstein
2020-09-30 14:05 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F741881.5020309@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox