public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: robbieko <robbieko@synology.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 4/4] xfstests: btrfs/134: add test for incremental send which renames a directory already being deleted
Date: Wed, 02 Nov 2016 11:52:00 +0800	[thread overview]
Message-ID: <5a436c110e0b823a9b6babedfe450734@synology.com> (raw)
In-Reply-To: <20161101072055.GQ27776@eguan.usersys.redhat.com>

Hi Eryu Guan,

Yes, it need apply
[PATCH] "Btrfs: incremental send, do not skip generation inconsistency 
check for inode 256."
and test again, it will failed.

because current code there is a problem, but just will not happen.

Thansk
Robbie Ko

Eryu Guan 於 2016-11-01 15:20 寫到:
> On Fri, Oct 28, 2016 at 09:44:06AM +0800, robbieko wrote:
>> From: Robbie Ko <robbieko@synology.com>
>> 
>> Test that an incremental send operation dosen't work because
>> it tries to rename a directory which is already deleted.
>> 
>> This test exercises scenarios used to fail in btrfs and are fixed by
>> the following patch for the linux kernel:
>> 
>> "Btrfs: incremental send, add generation check for inode is waiting 
>> for move."
> 
> I was testing with v4.9-rc1+ kernel and btrfs-progs v4.6. Seems above
> patch is not merged in 4.9-rc1 kernel, but test passed for me, is that
> expected?
> 
> Thanks,
> Eryu



  reply	other threads:[~2016-11-02  3:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28  1:44 [PATCH v2 0/4] Btrfs: add serval test case for incremental send robbieko
2016-10-28  1:44 ` [PATCH v2 1/4] xfstests: btrfs/131: add test for an incremental send with name collision robbieko
2016-11-01  7:17   ` Eryu Guan
2016-11-02  3:40     ` robbieko
2016-10-28  1:44 ` [PATCH v2 2/4] xfstests: btrfs/132: add test for invaild update time by an incremental send robbieko
2016-10-28  1:44 ` [PATCH v2 3/4] xfstests: btrfs/133: add test for incremental send with rmdir applied on wrong name robbieko
2016-10-28  1:44 ` [PATCH v2 4/4] xfstests: btrfs/134: add test for incremental send which renames a directory already being deleted robbieko
2016-11-01  7:20   ` Eryu Guan
2016-11-02  3:52     ` robbieko [this message]
2017-01-19 12:11       ` Filipe Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a436c110e0b823a9b6babedfe450734@synology.com \
    --to=robbieko@synology.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox