From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: XiaoLi Feng <xifeng@redhat.com>
Cc: <fstests@vger.kernel.org>
Subject: Re: [PATCH v2] common/rc: add filter in _test_inode_flag
Date: Thu, 18 Feb 2021 14:30:38 +0800 [thread overview]
Message-ID: <602E098E.9010509@cn.fujitsu.com> (raw)
In-Reply-To: <20210210083407.19184-1-xifeng@redhat.com>
On 2021/2/10 16:34, XiaoLi Feng wrote:
> From: Xiaoli Feng <xifeng@redhat.com>
>
> Add _filter_scratch and _filter_test_dir to avoid _test_inode_flag failed when
> mount point contains flag string.
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 649b1cfd..f3bb665e 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3112,7 +3112,7 @@ _test_inode_flag()
> local flag=$1
> local file=$2
>
> - if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | grep -q "$flag" ; then
> + if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | _filter_scratch | _filter_test_dir | grep -q "$flag" ; then
Hi XiaoLi,
Is it ok to use _filter_testdir_and_scratch directly?
Best Regards,
Xiao Yang
> return 0
> fi
> return 1
next prev parent reply other threads:[~2021-02-18 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 8:34 [PATCH v2] common/rc: add filter in _test_inode_flag XiaoLi Feng
2021-02-18 6:30 ` Xiao Yang [this message]
2021-02-18 8:49 ` Xiaoli Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=602E098E.9010509@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
--cc=xifeng@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox