From: Pankaj Raghav <p.raghav@samsung.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: <fstests@vger.kernel.org>, <zlang@redhat.com>,
Dave Chinner <david@fromorbit.com>, <mcgrof@kernel.org>,
<gost.dev@samsung.com>, <linux-xfs@vger.kernel.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
"Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
Subject: Re: fstest failure due to filesystem size for 16k, 32k and 64k FSB
Date: Tue, 30 Jan 2024 21:34:23 +0100 [thread overview]
Message-ID: <6bea58ad-5b07-4104-a6ff-a2c51a03bd2f@samsung.com> (raw)
In-Reply-To: <20240130195602.GJ1371843@frogsfrogsfrogs>
>> What should be the approach to solve this issue? 2 options that I had in my mind:
>>
>> 1. Similar to [2], we could add a small hack in mkfs xfs to ignore the log space
>> requirement while running fstests for these profiles.
>>
>> 2. Increase the size of filesystem under test to accommodate these profiles. It could
>> even be a conditional increase in filesystem size if the FSB > 16k to reduce the impact
>> on existing FS test time for 4k FSB.
>>
>> Let me know what would be the best way to move forward.
>>
>> Here are the results:
>>
>> Test environment:
>> kernel Release: 6.8.0-rc1
>> xfsprogs: 6.5.0
>> Architecture: aarch64
>> Page size: 64k
>>
>> Test matrix:
>>
>> | Test | 32k rmapbt=0 | 32k rmapbt=1 | 64k rmapbt=0 | 64k rmapbt=1 |
>> | -------- | --------- | --------- | --------- | --------- |
>> | generic/042 | fail | fail | fail | fail |
>> | generic/081 | fail | fail | pass | fail |
>> | generic/108 | fail | fail | pass | fail |
>> | generic/455 | fail | fail | pass | fail |
>> | generic/457 | fail | fail | pass | fail |
>> | generic/482 | fail | fail | pass | fail |
>> | generic/704 | fail | fail | pass | fail |
>> | generic/730 | fail | fail | pass | fail |
>> | generic/731 | fail | fail | pass | fail |
>> | shared/298 | pass | pass | pass | fail |
>
> I noticed test failures on these tests when running djwong-wtf:
> generic/042
> generic/081
> generic/108
> generic/219
> generic/305
> generic/326
> generic/562
> generic/704
> xfs/093
> xfs/113
> xfs/161
> xfs/262
> xfs/508
> xfs/604
> xfs/709
>
Ok, there are some more tests that I didn't catch. I will check them out.
> Still sorting through all of them, but a large portion of them are the
> same failure to format due to minimum log size constraints. I'd bump
> them up to ~500M (or whatever makes them work) since upstream doesn't
> really support small filesystems anymore.
Thanks for the reply. So we can have a small `if` conditional block for xfs
to have fs size = 500M in generic test cases.
We do this irrespective of filesystem blocksizes right? If we do that, then we can
remove the special conditional that allows tiny filesystems for fstests in mkfs
as well.
--
Pankaj
next prev parent reply other threads:[~2024-01-30 20:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240130131803eucas1p280d9355ca3f8dc94073aff54555e3820@eucas1p2.samsung.com>
2024-01-30 13:18 ` fstest failure due to filesystem size for 16k, 32k and 64k FSB Pankaj Raghav
2024-01-30 19:56 ` Darrick J. Wong
2024-01-30 20:34 ` Pankaj Raghav [this message]
2024-01-31 3:48 ` Darrick J. Wong
2024-01-31 14:05 ` Pankaj Raghav (Samsung)
2024-01-31 18:28 ` Darrick J. Wong
2024-02-01 15:44 ` Pankaj Raghav (Samsung)
2024-02-02 16:46 ` Darrick J. Wong
2024-02-02 17:18 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bea58ad-5b07-4104-a6ff-a2c51a03bd2f@samsung.com \
--to=p.raghav@samsung.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=gost.dev@samsung.com \
--cc=kernel@pankajraghav.com \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ritesh.list@gmail.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox