From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41862C2B9F4 for ; Thu, 17 Jun 2021 23:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CB3E61369 for ; Thu, 17 Jun 2021 23:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232862AbhFQXsU (ORCPT ); Thu, 17 Jun 2021 19:48:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:53652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbhFQXsU (ORCPT ); Thu, 17 Jun 2021 19:48:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DD21F61249; Thu, 17 Jun 2021 23:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623973571; bh=7mwg/crOE8MOnomtr0YZnpCv5QvULpNitjVriKwsW+g=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=Y9w9+2Wt22IZeBPapZ4RWDINw7zb5sx7a4NFoPwq/KsnVxnKRHgcyM+/+dYrWQkrx VNf5lLtkQc8YnBEdJG701rIUAR4WVakrxhePeG1rBtrkIRUmbJtC2N0IsihJl2sfoJ vtR4Yif6l0olOalVCmhvZVTqiD8mC//mPdvFPuFjofC0Ll3rj5aRo0yhxOGDSrw9GN 0HNZ7G9q6U08ePB34V8bwD/eL0tqSR2RE/x9UvOJopoEz1QILrbtMN3UX9OdakRHPo 7e9prZEZaUIQC1vqCl2GhnIQ4eklZwKHokFZCalfnQ8AKf9s6DSf2Jta9uQQNQfQAG E+JwssEvzL1YA== Subject: Re: [f2fs-dev] [PATCH] common/rc: f2fs do not support metadata journaling To: Sun Ke References: <20210611112211.1408767-1-sunke32@huawei.com> <258b1228-2a8a-e4c1-cf6c-695f49c0cca0@kernel.org> <963534d2-5a42-c4c6-8bc6-013f120ecffd@huawei.com> Cc: fstests@vger.kernel.org, guan@eryu.me, yuchao0@huawei.com, linux-f2fs-devel@lists.sourceforge.net From: Chao Yu Message-ID: <6d94d6c5-ca25-8c65-7e8a-b4c9c9b851dc@kernel.org> Date: Fri, 18 Jun 2021 07:46:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <963534d2-5a42-c4c6-8bc6-013f120ecffd@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On 2021/6/17 11:45, Sun Ke wrote: > > > 在 2021/6/16 20:36, Chao Yu 写道: >> On 2021/6/15 11:25, Sun Ke wrote: >>> >>> >>> 在 2021/6/11 19:22, Sun Ke 写道: >>>> In generic/50, touch 100 files, go down the fs immediately, Then umount >>>> and set the disk readi-only. Try to mount it again without \-o >>>> norecovery\, it should fail, because it can not recovery on a read-only >>>> device. But f2fs mount successfully and the test fail. >>>> >>>> f2fs seems do not support metadata journaling. >> >> It looks not correct. >> >> FYI, >> >> https://lkml.org/lkml/2021/3/23/75 >> >> Thanks, > Your patch should fix this bug, but it still fail in 5.13.0-rc5. It's due to that patch was not merged, please check details in that thread. Thanks, > > [root@localhost xfstests-dev]# ./check tests/generic/050 > FSTYP         -- f2fs > PLATFORM      -- Linux/x86_64 localhost 5.13.0-rc5 #2 SMP Wed Jun 16 20:36:54 CST 2021 > MKFS_OPTIONS  -- /dev/sdb > MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch > > generic/050 3s ... - output mismatch (see /root/work/xfstests-dev/results//generic/050.out.bad) >     --- tests/generic/050.out    2021-05-31 15:37:40.000000000 +0800 >     +++ /root/work/xfstests-dev/results//generic/050.out.bad    2021-06-17 11:40:26.107000000 +0800 >     @@ -13,9 +13,7 @@ >      setting device read-only >      mounting filesystem that needs recovery on a read-only device: >      mount: device write-protected, mounting read-only >     -mount: cannot mount device read-only >      unmounting read-only filesystem >     -umount: SCRATCH_DEV: not mounted >      mounting filesystem with -o norecovery on a read-only device: >     ... >     (Run 'diff -u /root/work/xfstests-dev/tests/generic/050.out /root/work/xfstests-dev/results//generic/050.out.bad'  to see the entire diff) > Ran: generic/050 > Failures: generic/050 > Failed 1 of 1 tests > > Thanks, > Sun Ke >> >>>> >>>> Signed-off-by: Sun Ke >>>> --- >>>> >>>> I am not very sure if f2fs do not support metadata journaling. >>>> >>>> ### >>>> before change >>>> ### >>>> [root@localhost xfstests-dev]# ./check tests/generic/050 >>>> FSTYP         -- f2fs >>>> PLATFORM      -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP Tue Jun 8 11:09:37 CST 2021 >>>> MKFS_OPTIONS  -- /dev/sdb >>>> MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch >>>> >>>> generic/050 4s ... - output mismatch (see /root/work/xfstests-dev/results//generic/050.out.bad) >>>>      --- tests/generic/050.out   2021-05-31 15:37:40.000000000 +0800 >>>>      +++ /root/work/xfstests-dev/results//generic/050.out.bad 2021-06-11 16:48:19.993000000 +0800 >>>>      @@ -13,9 +13,7 @@ >>>>       setting device read-only >>>>       mounting filesystem that needs recovery on a read-only device: >>>>       mount: device write-protected, mounting read-only >>>>      -mount: cannot mount device read-only >>>>       unmounting read-only filesystem >>>>      -umount: SCRATCH_DEV: not mounted >>>>       mounting filesystem with -o norecovery on a read-only device: >>>>      ... >>>>      (Run 'diff -u /root/work/xfstests-dev/tests/generic/050.out /root/work/xfstests-dev/results//generic/050.out.bad'  to see the entire diff) >>>> Ran: generic/050 >>>> Failures: generic/050 >>>> Failed 1 of 1 tests >>>> >>>> ### >>>> after change >>>> ### >>>> [root@localhost xfstests-dev]# ./check tests/generic/050 >>>> FSTYP         -- f2fs >>>> PLATFORM      -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP Tue Jun 8 11:09:37 CST 2021 >>>> MKFS_OPTIONS  -- /dev/sdb >>>> MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch >>>> >>>> generic/050 4s ...  4s >>>> Ran: generic/050 >>>> Passed all 1 tests >>>> >>>> >>>> >>>>   common/rc | 2 +- >>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/common/rc b/common/rc >>>> index a0aa7300..428b8b80 100644 >>>> --- a/common/rc >>>> +++ b/common/rc >>>> @@ -3543,7 +3543,7 @@ _has_metadata_journaling() >>>>       fi >>>>       case "$FSTYP" in >>>> -    ext2|vfat|msdos|udf|exfat|tmpfs) >>>> +    ext2|vfat|msdos|udf|exfat|tmpfs|f2fs) >>>>           echo "$FSTYP does not support metadata journaling" >>>>           return 1 >>>>           ;; >>>> >>> >>> >>> _______________________________________________ >>> Linux-f2fs-devel mailing list >>> Linux-f2fs-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >> .