From: Anand Jain <anand.jain@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/5] fstests: btrfs: add test case to validate sysfs input arguments
Date: Thu, 6 Feb 2025 07:30:14 +0800 [thread overview]
Message-ID: <6d95382c-181b-40ea-9096-37a16b68a3bc@oracle.com> (raw)
In-Reply-To: <Z6PWb__u9h25RCX4@dread.disaster.area>
On 6/2/25 05:21, Dave Chinner wrote:
> On Wed, Feb 05, 2025 at 07:06:35PM +0800, Anand Jain wrote:
>> v2:
>> Mainly adds a generic function to check if a sysfs attribute reports
>> invalid input.
>>
>> v1:
>> https://lwn.net/ml/all/cover.1738161075.git.anand.jain@oracle.com/
>>
>> Anand Jain (5):
>> fstests: common/rc: set_fs_sysfs_attr: redirect errors to stdout
>> fstests: filter: helper for sysfs error filtering
>> fstests: common/rc: add sysfs argument verification helpers
>> fstests: btrfs: testcase for sysfs policy syntax verification
>> fstests: btrfs: testcase for sysfs chunk_size attribute validation
>
> All looks ok, except for my comment about creating common/sysfs for
> all the sysfs stuff. The individual tests look much simpler and
> nicer, too.
>
Yeah, the sysfs functions need a new file. I'll send the reorg cleanups.
Thx, Anand
> -Dave.
prev parent reply other threads:[~2025-02-05 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 11:06 [PATCH v2 0/5] fstests: btrfs: add test case to validate sysfs input arguments Anand Jain
2025-02-05 11:06 ` [PATCH v2 1/5] fstests: common/rc: set_fs_sysfs_attr: redirect errors to stdout Anand Jain
2025-02-05 11:06 ` [PATCH v2 2/5] fstests: filter: helper for sysfs error filtering Anand Jain
2025-02-05 11:06 ` [PATCH v2 3/5] fstests: common/rc: add sysfs argument verification helpers Anand Jain
2025-02-05 21:19 ` Dave Chinner
2025-02-05 11:06 ` [PATCH v2 4/5] fstests: btrfs: testcase for sysfs policy syntax verification Anand Jain
2025-02-05 11:06 ` [PATCH v2 5/5] fstests: btrfs: testcase for sysfs chunk_size attribute validation Anand Jain
2025-02-05 21:21 ` [PATCH v2 0/5] fstests: btrfs: add test case to validate sysfs input arguments Dave Chinner
2025-02-05 23:30 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d95382c-181b-40ea-9096-37a16b68a3bc@oracle.com \
--to=anand.jain@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox