public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: JeffleXu <jefflexu@linux.alibaba.com>
To: fstests@vger.kernel.org
Cc: darrick.wong@oracle.com, guaneryu@gmail.com
Subject: [Fail] generic/530 check failed on overlay
Date: Wed, 8 May 2019 15:30:11 +0800	[thread overview]
Message-ID: <6f12fb93-59b8-ac1e-f182-e4340ede64a2@linux.alibaba.com> (raw)

When I run "./check -overlay generic/530", it failed with following log


```

generic/530 1s ... - output mismatch (see 
/root/xfstests/results//generic/530.out.bad)
     --- tests/generic/530.out   2019-05-07 16:18:55.951796117 +0800
     +++ /root/xfstests/results//generic/530.out.bad 2019-05-08 
14:55:30.976816701 +0800
     @@ -1,2 +1,3 @@
      QA output created by 530
     +shutdown: Inappropriate ioctl for device
      silence is golden
     ...

```


xfstests version: 1.1.1.1

kernel: linux 4.19

the commit that imports generic/530: e6703b90

https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?id=e6703b903a5025b3eccac758f5bdd8e847f62c39



I find that the error is due to the following snippet in 
src/t_open_tmpfiles.c


```c

ret = ioctl(min_fd, XFS_IOC_GOINGDOWN, &flag);
if (ret) {
     perror("shutdown");
     exit(2);
}

```


XFS_IOC_GOINGDOWN is specifically defined in XFS filesystem, while it is 
not

supported in overlay filesystem.


In my understanding, test cases in "tests/generic" should be generic for 
all

filesystem types, and the XFS_IOC_GOINGDOWN macro used by generic/530 is

obviously against this rule. Or maybe I missed something important and 
would

approciate if someone could give me some indication.


thx

             reply	other threads:[~2019-05-08  7:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08  7:30 JeffleXu [this message]
2019-05-09  1:54 ` [Fail] generic/530 check failed on overlay Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f12fb93-59b8-ac1e-f182-e4340ede64a2@linux.alibaba.com \
    --to=jefflexu@linux.alibaba.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox