From: Long An <lan@suse.com>
To: "david@fromorbit.com" <david@fromorbit.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] Fix input value to _scratch_mkfs_sized
Date: Fri, 17 Jun 2022 07:03:30 +0000 [thread overview]
Message-ID: <72edec0cedf5090a39bc80670129c42730b0dfab.camel@suse.com> (raw)
In-Reply-To: <20220617035836.GZ1098723@dread.disaster.area>
On Fri, 2022-06-17 at 13:58 +1000, Dave Chinner wrote:
> On Thu, Jun 16, 2022 at 12:38:43PM +0800, An Long wrote:
> > Function _scratch_mkfs_sized cannot recognize the size descriptor.
> >
> > For example, we set MKFS_OPTIONS="-b 4k" and then run generic/416
> > on
> > ext4, will fail with "mkfs.ext4: invalid block size - 4".
>
> So isn't the correct fix for this to use the correct format in
> MKFS_OPTIONS? ie. "-b 4096"?
>
MKFS_OPTIONS="-b 4096" will get the correct result 4096.
> i.e. why do we need ito add code to fix something that the user must
> specify themselves and could easily just use an integer to begin
> with?
>
This function must input an integer for now. But this function also
overwrites user input with MKFS_OPTIONS for compatibility. And for the
same reason MKFS_OPTIONS needs to receive such parameters as 4k.
> Cheers,
>
> Dave.
next prev parent reply other threads:[~2022-06-17 7:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 4:38 [PATCH v2 0/2] Fix input value to _scratch_mkfs_sized An Long
2022-06-16 4:38 ` [PATCH v2 1/2] common/rc: add _parse_size_string An Long
2022-06-16 15:25 ` Gabriel Krisman Bertazi
2022-06-17 6:45 ` Long An
2022-06-16 4:38 ` [PATCH v2 2/2] common/rc: fix input value to _scratch_mkfs_sized An Long
2022-06-17 3:58 ` [PATCH v2 0/2] Fix " Dave Chinner
2022-06-17 7:03 ` Long An [this message]
2022-06-17 17:52 ` Zorro Lang
2022-06-17 22:24 ` Dave Chinner
2022-06-18 3:14 ` Zorro Lang
2022-06-20 23:12 ` Dave Chinner
2022-06-21 4:05 ` Zorro Lang
2022-06-21 4:25 ` Long An
2022-06-21 4:40 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72edec0cedf5090a39bc80670129c42730b0dfab.camel@suse.com \
--to=lan@suse.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox