Re: [PATCH fstests v3 3/3] generic: add tests for file delegations

[Jeff Layton <jlayton@kernel.org>]

On Tue, 2026-01-06 at 21:58 -0800, Christoph Hellwig wrote:
> On Tue, Jan 06, 2026 at 06:09:24AM -0500, Jeff Layton wrote:
> > On Mon, 2026-01-05 at 22:28 -0800, Christoph Hellwig wrote:
> > > On Wed, Dec 03, 2025 at 10:43:09AM -0500, Jeff Layton wrote:
> > > > Mostly the same ones as leases, but some additional tests to validate
> > > > that they are broken on metadata changes.
> > > 
> > > Under what conditions is this test supposed to actually work?  It seems
> > > to consistently fail for me even with latest mainline, which is a bit
> > > annoying.
> > 
> > There is a patch that is not yet merged:
> 
> Thanks.  Also what is the story with generic/786 on NFS?
> 
> It seems to constantly fail for me:
> 
> generic/786  5s ... [   17.862569] run fstests generic/786 at 2026-01-07 05:29:40
> [failed, exit status 1]- output mismatch (see /root/xfstests-dev/results//generic/786.out.bad)
>     --- tests/generic/786.out	2025-12-18 06:25:33.420000000 +0000
>     +++ /root/xfstests-dev/results//generic/786.out.bad	2026-01-07 05:29:47.576897353 +0000
>     @@ -1,2 +1,3 @@
>      QA output created by 786
>     -success!
>     +Server reported failure (1)
>     +(see /root/xfstests-dev/results//generic/786.full for details)
>     ...
>     (Run 'diff -u /root/xfstests-dev/tests/generic/786.out /root/xfstests-dev/results//generic/786.out.bad'  to see the entire diff)

Mea culpa.

I missed the fact that directories have a different set of
file_operations on NFS here, and those don't have the ->setlease method
set. It's a simple fix, but it looks like I'll need to do this in some
other filesystems too. I'll send a follow-on series soon.

Thanks,
-- 
Jeff Layton <jlayton@kernel.org>