From: Arnd Bergmann <arnd@arndb.de>
To: Eryu Guan <eguan@redhat.com>
Cc: Deepa Dinamani <deepa.kernel@gmail.com>,
fstests@vger.kernel.org, y2038@lists.linaro.org
Subject: Re: [PATCH] generic/390: Add tests for inode timestamp policy
Date: Fri, 25 Nov 2016 13:20:28 +0100 [thread overview]
Message-ID: <7538941.tpP0Pki3Hl@wuerfel> (raw)
In-Reply-To: <20161124104055.GD4609@eguan.usersys.redhat.com>
On Thursday, November 24, 2016 6:40:55 PM CET Eryu Guan wrote:
> On Wed, Nov 23, 2016 at 04:52:02PM -0800, Deepa Dinamani wrote:
> > +_filesystem_timestamp_range()
> > +{
> > + device=${1:-$TEST_DEV}
> > + case $FSTYP in
> > + ext4) #dumpe2fs
> > + if [ $(dumpe2fs -h $device 2>/dev/null | grep "Inode size:" | cut -d: -f2) -gt 128 ]; then
> > + echo "-2147483648 15032385535"
> > + else
> > + echo "-2147483648 2147483647"
> > + fi
>
> Do ext3 and ext2 follow the same config as ext4?
Those two only support the second case with 128 byte inodes, but the same
check should work on all three.
I have an overview of the limits on https://kernelnewbies.org/y2038/vfs,
though I'd probably check all of them again, as some of them turned out
to be wrong. In particular, identifying whether the on-disk timestamps
are meant to be signed or unsigned can be a matter of interpretation
and there may be a specification that disagrees with the implementation.
Arnd
next prev parent reply other threads:[~2016-11-25 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 0:52 [PATCH] generic/390: Add tests for inode timestamp policy Deepa Dinamani
2016-11-24 10:40 ` Eryu Guan
2016-11-25 12:20 ` Arnd Bergmann [this message]
2016-12-02 20:44 ` Deepa Dinamani
2016-12-02 18:26 ` Deepa Dinamani
2016-11-24 23:15 ` Dave Chinner
2016-12-03 1:43 ` Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7538941.tpP0Pki3Hl@wuerfel \
--to=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox