FS/XFS testing framework
 help / color / mirror / Atom feed
From: An Long <lan@suse.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v3] generic/746: install two necessary files
Date: Thu, 10 Oct 2024 19:01:15 +0800	[thread overview]
Message-ID: <7598cd96388b0eb87b111e30f1157d37f5ec03cf.camel@suse.com> (raw)
In-Reply-To: <20241010094423.mnyaf5bljmeylxri@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>

On Thu, 2024-10-10 at 17:44 +0800, Zorro Lang wrote:
> On Thu, Oct 10, 2024 at 11:40:20AM +0800, An Long wrote:
> > parse-dev-tree.awk and parse-extent-tree.awk are used by
> > generic/746.
> > We need to make sure them are installed, otherwise generic/746 will
> > have problems if fstests is installed via "make install".
> > 
> > Signed-off-by: An Long <lan@suse.com>
> > ---
> 
> There might be something (format) wrong when you generated or sent
> this
> patch, I can't merge it directly, the `git am` shows:
> 
>   Applying: generic/746: install two necessary files
>   error: corrupt patch at line 18
>   Patch failed at 0001 generic/746: install two necessary files
>   hint: Use 'git am --show-current-patch=diff' to see the failed
> patch
>   hint: When you have resolved this problem, run "git am --continue".
>   hint: If you prefer to skip this patch, run "git am --skip"
> instead.
>   hint: To restore the original branch and stop patching, run "git am
> --abort".
>   hint: Disable this message with "git config advice.mergeConflict
> false"
> 
> Anyway, this change is simple enough, so I've maken this change
> manually
> (with author=$you), so don't need to send one more version, just
> remind it.
> 
> Thanks,
> Zorro
Thank you, Lang! I've double checked, there is a "=20"(space) in the
end of mail. However, I'll ensure the format is correct next time.
> 
> >  src/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/Makefile b/src/Makefile
> > index 3097c29e..a0396332 100644
> > --- a/src/Makefile
> > +++ b/src/Makefile
> > @@ -38,7 +38,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize
> > preallo_rw_pattern_reader \
> > 
> >  EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh
> > \
> >               btrfs_crc32c_forged_name.py popdir.pl popattr.py \
> > -             soak_duration.awk
> > +             soak_duration.awk parse-dev-tree.awk parse-extent-
> > tree.awk
> > 
> >  SUBDIRS = log-writes perf
> > 
> > -- 
> > 2.43.0
> > 
> > 
> 

-- 
An Long <lan@suse.com>
SUSE QE LSG, QE 2, Beijing

      reply	other threads:[~2024-10-10 11:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10  3:40 [PATCH v3] generic/746: install two necessary files An Long
2024-10-10  6:13 ` Zorro Lang
2024-10-10  9:44 ` Zorro Lang
2024-10-10 11:01   ` An Long [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7598cd96388b0eb87b111e30f1157d37f5ec03cf.camel@suse.com \
    --to=lan@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox