From: Baokun Li <libaokun1@huawei.com>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: Zorro Lang <zlang@redhat.com>, <fstests@vger.kernel.org>,
Leah Rumancik <lrumancik@google.com>,
<linux-ext4@vger.kernel.org>, Yang Erkun <yangerkun@huawei.com>
Subject: Re: [PATCH] ext4/048: Fix hangup due to no free inodes
Date: Tue, 28 Oct 2025 19:34:34 +0800 [thread overview]
Message-ID: <7bb8d73b-6394-4cb2-9e36-76cfbd584a76@huawei.com> (raw)
In-Reply-To: <aQCPQ1V8DuAMpmVc@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com>
On 2025-10-28 17:39, Ojaswin Mujoo wrote:
> On Tue, Oct 28, 2025 at 03:57:00PM +0800, Baokun Li wrote:
>> On 2025-10-28 15:17, Ojaswin Mujoo wrote:
>>> We currently mkfs a 128MB filesystem, which gives use ~2048 free inodes
>>> on 64k blocksize. The test then keeps adding new files to a directory to
>>> trigger an htree split. For 64k this takes more than the total free
>>> inodes, which causes touch to return -ENOSPC. This leads to the while
>>> loop in induce_node_split() to never finish.
>>>
>>> To fix this:
>>> 1. Format a 1G FS which gives us atleast 16K inodes to work with.
>>> 2. _fail if there's any error while trying to induce node split, so we
>>> dont get stuck in loop
>>>
>>> Fixes: 466ddbfd1151 ("ext4: add test for ext4_dir_entry2 wipe")
>>> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
>>> ---
>> Yeah, I also hit this issue when testing LBS — file creation kept failing
>> without breaking out of the loop, which resulted in the test case spinning
>> endlessly.
>>
>> Looks good to me. Feel free to add:
>>
>> Reviewed-by: Baokun Li <libaokun1@huawei.com>
> Hi Baokun, I was planning to CC you since I thought you might've hit it,
> but missed it while sending the mail.
No worries, the mailing list can see it as well.
Thanks for testing and fixing this. 🤝
Cheers,
Baokun
prev parent reply other threads:[~2025-10-28 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 7:17 [PATCH] ext4/048: Fix hangup due to no free inodes Ojaswin Mujoo
2025-10-28 7:57 ` Baokun Li
2025-10-28 9:39 ` Ojaswin Mujoo
2025-10-28 11:34 ` Baokun Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bb8d73b-6394-4cb2-9e36-76cfbd584a76@huawei.com \
--to=libaokun1@huawei.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=lrumancik@google.com \
--cc=ojaswin@linux.ibm.com \
--cc=yangerkun@huawei.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox