From: "Misono, Tomohiro" <misono.tomohiro@jp.fujitsu.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs/029: fix wrong usage of name filter
Date: Thu, 31 Aug 2017 08:53:09 +0900 [thread overview]
Message-ID: <80ddf7d2-043c-6228-e1d8-e6a463668080@jp.fujitsu.com> (raw)
In-Reply-To: <20170830110934.GF27835@eguan.usersys.redhat.com>
On 2017/08/30 20:09, Eryu Guan wrote:
> On Wed, Aug 30, 2017 at 04:38:16PM +0900, Misono, Tomohiro wrote:
>> btrfs/029 uses _filter_testdirs() to filter the name of $TEST_DIR and
>> $SCRATCH_MNT directory.
>>
>> In this function, it calls both _filter_test_dir and _filter_scratch
>> concatenapted by pipe. Therefore if $TEST_DIR is a prefix of
>> $SCRATCH_MNT, this filter function gives wrong filtered name for
>> $SCRATCH_MNT and the test fails.
>
> Sorry, I'm a bit confused, how could $TEST_DIR be a prefix of
> $SCRATCH_MNT? Won't that fail the test at setup time?
I used "/mnt" for $TEST_DIR and "/mnt_scratch" for $SCRATCH_MNT and hit
this problem because "/mnt_scratch" is filtered to "$TEST_DIR_scrach"
instead of "$SCRATCH_MNT".
I think these are valid directory names and other btrfs tests run correctly
with these names.
Thanks,
Tomohiro
next prev parent reply other threads:[~2017-08-30 23:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 7:38 [PATCH] btrfs/029: fix wrong usage of name filter Misono, Tomohiro
2017-08-30 11:09 ` Eryu Guan
2017-08-30 23:53 ` Misono, Tomohiro [this message]
2017-08-31 7:33 ` Eryu Guan
2017-09-01 0:44 ` Misono, Tomohiro
2017-09-01 3:47 ` Eryu Guan
-- strict thread matches above, loose matches on Subject: below --
2017-08-30 2:44 Misono, Tomohiro
2017-08-30 6:56 ` Misono, Tomohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ddf7d2-043c-6228-e1d8-e6a463668080@jp.fujitsu.com \
--to=misono.tomohiro@jp.fujitsu.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox