From: Jeff Layton <jlayton@kernel.org>
To: stsp <stsp2@yandex.ru>, fstests@vger.kernel.org
Cc: Murphy Zhou <xzhou@redhat.com>, Zorro Lang <zlang@redhat.com>
Subject: Re: [PATCH][RESEND] generic/478: add F_UNLCK testing
Date: Tue, 03 Oct 2023 14:30:12 -0400 [thread overview]
Message-ID: <82cc1f923b76f076be0808de50aff79becf673f0.camel@kernel.org> (raw)
In-Reply-To: <163917ba-5597-493a-9856-560ed49df889@yandex.ru>
On Tue, 2023-10-03 at 22:43 +0500, stsp wrote:
>
>
>
>
>
>
>
> 03.10.2023 22:39, Jeff Layton пишет:
>
>
> >
> >
> > The problem here is that old kernels are going to fail the new tests,
> > and it's going to be hard to engineer the output of 478 to account for
> > that.
> >
> >
>
>
> What do you mean?
> My patch does exactly that, and for
> that I added the -U option.
>
>
I mean that that functionality would be better implemented as a
_require_* test rather than hidden plumbing inside t_ofd_locks.c like
that.
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-10-03 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 11:00 [PATCH][RESEND] generic/478: add F_UNLCK testing Stas Sergeev
2023-10-03 17:39 ` Jeff Layton
[not found] ` <163917ba-5597-493a-9856-560ed49df889@yandex.ru>
2023-10-03 18:30 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82cc1f923b76f076be0808de50aff79becf673f0.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=stsp2@yandex.ru \
--cc=xzhou@redhat.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox