From: Florian Weimer <fw@deneb.enyo.de>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Paul Smith <psmith@gnu.org>, Zorro Lang <zlang@redhat.com>,
fstests@vger.kernel.org, bug-make@gnu.org,
Jim Meyering <meyering@fb.com>
Subject: Re: xfstests can't be installed by running make install
Date: Tue, 17 Jul 2018 22:15:47 +0200 [thread overview]
Message-ID: <87muupipos.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: 20180717033214.GJ2830@desktop
* Eryu Guan:
> This problem here doesn't seem the same as the bug above, Fedora 28 has
> glibc-2.27, which contains the fix for above bug, and the bug is about
> trailing "/". But the problem here is we're asking for all lower case
> filenames but wildcard returns upper case names too. e.g.
>
> [root@fedoravm tmp]# pwd
> /root/tmp
> [root@fedoravm tmp]# ls -l
> total 4
> -rw-r--r--. 1 root root 0 Jul 17 10:51 aaa
> -rw-r--r--. 1 root root 0 Jul 17 10:51 AAA
> -rw-r--r--. 1 root root 273 Jul 17 10:50 Makefile
> drwxr-xr-x. 1 root root 0 Jul 15 14:59 testdir
> [root@fedoravm tmp]# cat Makefile
> STRING1 = $(wildcard $(CURDIR)/[a-z]*/)
> STRING2 = $(wildcard ./[a-z]*/)
> STRING3 = $(wildcard $(CURDIR)/[a-z]*/.)
> STRING4 = $(wildcard $(CURDIR)/[a-z]*)
> default:
> @echo STRING1="$(STRING1)"
> @echo STRING2="$(STRING2)"
> @echo STRING3="$(STRING3)"
> @echo STRING4="$(STRING4)"
> [root@fedoravm tmp]# make
> STRING1=/root/tmp/aaa /root/tmp/AAA /root/tmp/testdir/ /root/tmp/Makefile
> STRING2=./aaa ./AAA ./testdir/ ./Makefile
> STRING3=/root/tmp/testdir/.
> STRING4=/root/tmp/aaa /root/tmp/AAA /root/tmp/testdir /root/tmp/Makefile
> [root@fedoravm tmp]#
>
> STRING4 is asking for all lower file names, but both "AAA" and
> "Makefile" are returned.
This is related to this glibc bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=23393
The bug mentions the regular expression [0-9], but it also affects
patterns like [a-z]. I have not yet looked at fnmatch and glob in
detail, but based on the report here (and a quick test with “echo
[a-z]*”), they are affected by the same issue.
This is ultimately caused by a locale data update which was backported
into Fedora 28 (glibc 2.27) and its derivatives. Upstream glibc only
has this change for version 2.28 (not yet released). It's currently
not considered a release blocker, if it's even considered a bug at
all.
I dimly recall earlier discussions regarding this matter quite some
time ago, perhaps in the POSIX context. GNU grep appears to have a
workaround for [0-9], but not [a-z]. Cc:ing Jim Meyering in case he
has any insights.
next prev parent reply other threads:[~2018-07-17 20:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 14:33 xfstests can't be installed by running make install Zorro Lang
2018-07-11 16:39 ` Eryu Guan
2018-07-11 16:54 ` Zorro Lang
2018-07-15 5:43 ` Dave Chinner
2018-07-15 7:11 ` Eryu Guan
2018-07-16 7:30 ` Zorro Lang
2018-07-16 11:48 ` Paul Smith
2018-07-17 3:32 ` Eryu Guan
2018-07-17 20:15 ` Florian Weimer [this message]
2018-07-17 22:58 ` Dave Chinner
2018-07-18 6:26 ` Florian Weimer
2018-07-18 3:15 ` Zorro Lang
2018-07-18 3:47 ` Zorro Lang
2018-07-18 4:05 ` Zorro Lang
2018-07-18 6:04 ` Florian Weimer
2018-07-18 8:31 ` Zorro Lang
2018-07-18 8:47 ` Florian Weimer
2018-07-18 10:12 ` Zorro Lang
2018-07-18 10:19 ` Zorro Lang
2018-07-19 16:21 ` Florian Weimer
2018-07-20 2:12 ` Zorro Lang
2018-07-18 10:56 ` spagoveanu
2018-07-17 5:24 ` Dave Chinner
2018-07-17 5:57 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muupipos.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=bug-make@gnu.org \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=meyering@fb.com \
--cc=psmith@gnu.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox