From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8F501E377A for ; Tue, 7 Jan 2025 11:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.118 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736249935; cv=none; b=O8UYdVvH+a2AESfVflXHGl4w6xP+kXCV+jf18JuQ0VqGbJcn63DcFCZTlBE8rJhRxtCVjoZtI42Poz4ck9VMReSJPRWT9b91cEOPmgXkbRcxvcgdUYiBmwDHU91DRKMbgGdnEdzphKsBl2047UGShaDHUCFR+cD9FFoANSHR/kc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736249935; c=relaxed/simple; bh=PrB3Fr4s7FDtwbweDg17cRAzzQYBQLQFf9cCFMCGveA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QTJYRpC5o/zeDyAZW6mL1w8IN13Pe2gVC0n8+kEP/FVh+lQJ05iNvyCQ1xc0RzQGDITKZ88stMsioqBW6Ux9rqZVr7+67pxfK2SNfbW0KDs9bVgtJkDxuqEFNj+B/bZ9gnYq/OqJdTSaefLNEgSEUzKpJSuvqgHNyJQf3HpDkmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=WvHdIXkv; arc=none smtp.client-ip=115.124.30.118 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="WvHdIXkv" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1736249928; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=McX/q3p/SAm7qC/JWTu4ugEzfTM3XFkHG1Eid3ybb6k=; b=WvHdIXkv7xgY31x0lFysqUcSGxJru1Ez0GiaxNQs2yjDkoxcILv8+lMRuTI5IX4rDbYf26lhDEPwBkFbhv7OUU9g+eahirMbzttTsK6YFGQOgKXMEIawPKzpf62OhxQWfpjCmwOgKbOKLLYpNnZAu6kM/eIbrMaAhWjem1cuPa0= Received: from 30.221.129.26(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0WNATcYC_1736249927 cluster:ay36) by smtp.aliyun-inc.com; Tue, 07 Jan 2025 19:38:47 +0800 Message-ID: <88b41e58-2878-4719-8efe-446c58b1f5e1@linux.alibaba.com> Date: Tue, 7 Jan 2025 19:38:45 +0800 Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] generic/620: add '-J block64' mkfs option for ocfs2 To: Glass Su , "Darrick J. Wong" , Mark Fasheh Cc: fstests@vger.kernel.org, ocfs2-devel@lists.linux.dev References: <20250106140104.91880-1-glass.su@suse.com> <20250107021254.GP6160@frogsfrogsfrogs> <6B45499F-7306-478A-A860-73E02D47FCF3@suse.com> From: Joseph Qi In-Reply-To: <6B45499F-7306-478A-A860-73E02D47FCF3@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2025/1/7 10:42, Glass Su wrote: > > >> On Jan 7, 2025, at 10:12, Darrick J. Wong wrote: >> >> On Mon, Jan 06, 2025 at 10:01:04PM +0800, Su Yue wrote: >>> mkfs.ocfs2 is using 32bit journal as default. >>> For 16T size device support, '-J block64' should be used. >>> >>> Signed-off-by: Su Yue >>> --- >>> tests/generic/620 | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/tests/generic/620 b/tests/generic/620 >>> index 3f1ce45a55fd..60e5a2cacdda 100755 >>> --- a/tests/generic/620 >>> +++ b/tests/generic/620 >>> @@ -41,6 +41,9 @@ sectors=$((2*1024*1024*1024*17)) >>> chunk_size=128 >>> >>> _dmhugedisk_init $sectors $chunk_size >>> + >>> +[ "$FSTYP" = "ocfs2" ] && MKFS_OPTIONS="$MKFS_OPTIONS -J block64" >> >> Won't mkfs.ocfs2 turn on block64 on a > 16T volume without prompting? >> > It won’t. Only error will be printed: > > ERROR: jbd can only store block numbers in 32 bits. /dev/mapper/huge-test.620 can hold 4563402752 blocks > which overflows this limit. If you have a new enough Ocfs2 with JBD2 support, you can try formatting with the "-Jblock64" option to turn on support for this size block device. > > It’s 2025 now. Maybe it’s time to make mkfs.ocfs2 turn on block64 if device size > 16T. > > Maintainers may know some stories. Joseph? > AFAIK, standard 32-bit journal is the default journal format for ocfs2 since the beginning.