FS/XFS testing framework
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@fujitsu.com>
To: "Darrick J. Wong" <djwong@kernel.org>, <zlang@redhat.com>
Cc: <linux-xfs@vger.kernel.org>, <fstests@vger.kernel.org>, <guan@eryu.me>
Subject: Re: [PATCH 2/3] xfs: fix reflink test failures when dax is enabled
Date: Wed, 18 Jan 2023 13:10:40 +0800	[thread overview]
Message-ID: <91105186-e4df-fb33-5f8e-f5aa6bf8a0ef@fujitsu.com> (raw)
In-Reply-To: <167400102472.1914858.16726369189467075623.stgit@magnolia>

Hi Darrick,

Thanks for your quick fix. It's better than my patch.
Reviewed-by: Xiao Yang <yangx.jy@fujitsu.com>

Best Regards,
Xiao Yang

On 2023/1/18 8:42, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Turn off reflink tests that require delayed allocation to work, because
> we don't use delayed allocation when fsdax mode is turned on.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>   tests/xfs/184 |    1 +
>   tests/xfs/192 |    1 +
>   tests/xfs/200 |    1 +
>   tests/xfs/204 |    1 +
>   tests/xfs/232 |    1 +
>   tests/xfs/440 |    1 +
>   6 files changed, 6 insertions(+)
> 
> 
> diff --git a/tests/xfs/184 b/tests/xfs/184
> index c251040e8a..3bdd86addf 100755
> --- a/tests/xfs/184
> +++ b/tests/xfs/184
> @@ -19,6 +19,7 @@ _begin_fstest auto quick clone fiemap unshare
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_xfs_io_command "fiemap"
> diff --git a/tests/xfs/192 b/tests/xfs/192
> index 85ed7a48fc..ced18fa3c1 100755
> --- a/tests/xfs/192
> +++ b/tests/xfs/192
> @@ -19,6 +19,7 @@ _begin_fstest auto quick clone fiemap unshare
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_xfs_io_command "fiemap"
> diff --git a/tests/xfs/200 b/tests/xfs/200
> index f91bfbf478..b51b9a54f5 100755
> --- a/tests/xfs/200
> +++ b/tests/xfs/200
> @@ -21,6 +21,7 @@ _begin_fstest auto quick clone fiemap unshare
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_xfs_io_command "fiemap"
> diff --git a/tests/xfs/204 b/tests/xfs/204
> index d034446bbc..ca21dfe722 100755
> --- a/tests/xfs/204
> +++ b/tests/xfs/204
> @@ -21,6 +21,7 @@ _begin_fstest auto quick clone fiemap unshare
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_xfs_io_command "fiemap"
> diff --git a/tests/xfs/232 b/tests/xfs/232
> index f402ad6cf3..59bbc43686 100755
> --- a/tests/xfs/232
> +++ b/tests/xfs/232
> @@ -30,6 +30,7 @@ _cleanup()
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_xfs_io_command "cowextsize"
>   _require_scratch_reflink
>   _require_cp_reflink
> diff --git a/tests/xfs/440 b/tests/xfs/440
> index 496ee04edf..368ee8a05d 100755
> --- a/tests/xfs/440
> +++ b/tests/xfs/440
> @@ -20,6 +20,7 @@ _begin_fstest auto quick clone quota
>   _supported_fs xfs
>   
>   _require_quota
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_user
> 

  reply	other threads:[~2023-01-18  5:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  0:41 [PATCHSET 0/3] fstests: fix dax+reflink tests Darrick J. Wong
2023-01-18  0:42 ` [PATCH 1/3] xfs: fix dax inode flag test failures Darrick J. Wong
2023-01-18  6:55   ` Xiao Yang
2023-01-18  0:42 ` [PATCH 2/3] xfs: fix reflink test failures when dax is enabled Darrick J. Wong
2023-01-18  5:10   ` Xiao Yang [this message]
2023-01-18  0:42 ` [PATCH 3/3] xfs/182: fix spurious direct write failure Darrick J. Wong
2023-01-18  5:13   ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91105186-e4df-fb33-5f8e-f5aa6bf8a0ef@fujitsu.com \
    --to=yangx.jy@fujitsu.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox