FS/XFS testing framework
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: Amir Goldstein <amir73il@gmail.com>, Zorro Lang <zlang@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	Christian Brauner <brauner@kernel.org>,
	linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 2/3] fstests: add helper _require_xfs_io_shutdown
Date: Mon, 9 Jun 2025 17:20:54 -0300	[thread overview]
Message-ID: <96a8fa69-456d-41eb-a30e-338a0b77e813@igalia.com> (raw)
In-Reply-To: <20250609151915.2638057-3-amir73il@gmail.com>

Hi Amir,

Em 09/06/2025 12:19, Amir Goldstein escreveu:
> Requirements for tests that shutdown fs using "xfs_io -c shutdown".
> The requirements are stricter than the requirement for tests that
> shutdown fs using _scratch_shutdown helper.
> 
> Generally, with overlay fs, tests can do _scratch_shutdown, but not
> xfs_io -c shutdown.
> 
> Encode this stricter requirement in helper _require_xfs_io_shutdown
> and use it in test generic/623, to express that it cannot run on
> overalyfs.
> 
> Reported-by: André Almeida <andrealmeid@igalia.com>
> Link: https://lore.kernel.org/linux-fsdevel/20250521-ovl_ro-v1-1-2350b1493d94@igalia.com/
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---

Thanks for the fix!

Tested-by: André Almeida <andrealmeid@igalia.com>

  reply	other threads:[~2025-06-09 20:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 15:19 [PATCH 0/3] fstests overlay updates for 6.16-rc1 Amir Goldstein
2025-06-09 15:19 ` [PATCH 1/3] fstests: add helper _scratch_shutdown_and_syncfs Amir Goldstein
2025-06-10 14:37   ` Darrick J. Wong
2025-06-18 15:18   ` Zorro Lang
2025-06-09 15:19 ` [PATCH 2/3] fstests: add helper _require_xfs_io_shutdown Amir Goldstein
2025-06-09 20:20   ` André Almeida [this message]
2025-06-10 14:42   ` Darrick J. Wong
2025-06-10 18:34     ` Amir Goldstein
2025-06-10 19:02       ` Darrick J. Wong
2025-06-18 15:20   ` Zorro Lang
2025-06-09 15:19 ` [PATCH 3/3] overlay/08[89]: add tests for data-only redirect with userxattr Amir Goldstein
2025-06-18 16:02   ` Zorro Lang
2025-06-18 18:46     ` Amir Goldstein
2025-06-10 18:00 ` [PATCH 0/3] fstests overlay updates for 6.16-rc1 André Almeida
2025-06-10 18:25   ` Amir Goldstein
2025-06-18 14:56 ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96a8fa69-456d-41eb-a30e-338a0b77e813@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox