Re: [PATCH] selftest: add a test that flakes

[Leah <leah.rumancik@gmail.com>]

Great! Thanks everyone!

- leah

> On May 12, 2025, at 8:47 PM, Zorro Lang <zlang@redhat.com> wrote:
> 
> On Mon, May 12, 2025 at 08:19:49AM -0700, Darrick J. Wong wrote:
>>> On Mon, May 12, 2025 at 07:32:15PM +0530, Nirjhar Roy (IBM) wrote:
>>> On Fri, 2025-05-09 at 17:42 -0700, Leah Rumancik wrote:
>>>> Add selftest/007 which should fail about half of the time.
>>> 
>>> I have already posted something similar[1] a couple of months back. It got an approval didn't get
>>> picked up.
>>> [1] https://lore.kernel.org/all/20250113164639.GG1251194@frogsfrogsfrogs/
>> 
>> Aha, I /was/ thinking "Gee , haven't I reviewed this before?"
> 
> Oh, that patchset is marked with RFC, and most of patches aren't acked (except
> the 1/5), so I didn't merge it and wait later updates.
> 
>> 
>> Zorro: any plans to merge
>> https://lore.kernel.org/all/03ba6c154c9e2cf3d68131b3af2ca12b96663d25.1736496620.git.nirjhar.roy.lists@gmail.com/ ?
> 
> Sure, I'll pick up that single patch to merge at first, as it's gotten enough
> acks :)
> 
> Thanks,
> Zorro
> 
>> 
>> --D
>> 
>>> --NR
>>>> 
>>>> Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
>>>> ---
>>>> tests/selftest/007     | 14 ++++++++++++++
>>>> tests/selftest/007.out |  3 +++
>>>> 2 files changed, 17 insertions(+)
>>>> create mode 100755 tests/selftest/007
>>>> create mode 100644 tests/selftest/007.out
>>>> 
>>>> diff --git a/tests/selftest/007 b/tests/selftest/007
>>>> new file mode 100755
>>>> index 00000000..0e983b37
>>>> --- /dev/null
>>>> +++ b/tests/selftest/007
>>>> @@ -0,0 +1,14 @@
>>>> +#! /bin/bash
>>>> +# SPDX-License-Identifier: GPL-2.0
>>>> +#
>>>> +# FS QA Test No. 007
>>>> +#
>>>> +# A test that flakes due to occasional output mismatch
>>>> +#
>>>> +. ./common/preamble
>>>> +_begin_fstest selftest
>>>> +
>>>> +echo "I am intentionally flaky"
>>>> +echo $((RANDOM % 2))
>>>> +status=0
>>>> +exit
>>>> diff --git a/tests/selftest/007.out b/tests/selftest/007.out
>>>> new file mode 100644
>>>> index 00000000..0b5e439a
>>>> --- /dev/null
>>>> +++ b/tests/selftest/007.out
>>>> @@ -0,0 +1,3 @@
>>>> +QA output created by 007
>>>> +I am intentionally flaky
>>>> +0
>>> 
>>> 
>> 
>