Re: [PATCH 2/3] fstests: add missing require of xfs_io fiemap command to some tests

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Oct 07, 2022 at 02:53:35PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> btrfs/257, btrfs/258, btrfs/259 and xfs/443 use the fiemap command of
> xfs_io but don't do a '_require_xfs_io_command "fiemap"'. So add the
> missing requirement.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Yep
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/btrfs/257 | 1 +
>  tests/btrfs/258 | 1 +
>  tests/btrfs/259 | 1 +
>  tests/xfs/443   | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/tests/btrfs/257 b/tests/btrfs/257
> index 3092495f..87f9e0b2 100755
> --- a/tests/btrfs/257
> +++ b/tests/btrfs/257
> @@ -33,6 +33,7 @@ _require_btrfs_no_compress
>  # Needs 4K sectorsize
>  _require_btrfs_support_sectorsize 4096
>  _require_xfs_io_command "falloc"
> +_require_xfs_io_command "fiemap"
>  
>  _scratch_mkfs -s 4k >> $seqres.full 2>&1
>  
> diff --git a/tests/btrfs/258 b/tests/btrfs/258
> index da073333..be61d039 100755
> --- a/tests/btrfs/258
> +++ b/tests/btrfs/258
> @@ -17,6 +17,7 @@ _begin_fstest auto defrag quick
>  # Modify as appropriate.
>  _supported_fs generic
>  _require_scratch
> +_require_xfs_io_command "fiemap"
>  
>  # Needs 4K sectorsize, as larger sectorsize can change the file layout.
>  _require_btrfs_support_sectorsize 4096
> diff --git a/tests/btrfs/259 b/tests/btrfs/259
> index 92d0b9a6..36f499f9 100755
> --- a/tests/btrfs/259
> +++ b/tests/btrfs/259
> @@ -18,6 +18,7 @@ _begin_fstest auto quick defrag
>  # Modify as appropriate.
>  _supported_fs btrfs
>  _require_scratch
> +_require_xfs_io_command "fiemap"
>  
>  _scratch_mkfs >> $seqres.full
>  
> diff --git a/tests/xfs/443 b/tests/xfs/443
> index f2390bf3..de28b85b 100755
> --- a/tests/xfs/443
> +++ b/tests/xfs/443
> @@ -30,6 +30,7 @@ _require_test_program "punch-alternating"
>  _require_xfs_io_command "falloc"
>  _require_xfs_io_command "fpunch"
>  _require_xfs_io_command "swapext"
> +_require_xfs_io_command "fiemap"
>  
>  _scratch_mkfs | _filter_mkfs >> $seqres.full 2> $tmp.mkfs
>  _scratch_mount
> -- 
> 2.35.1
>